aboutsummaryrefslogtreecommitdiffstats
path: root/spec
Commit message (Collapse)AuthorAgeLines
* Do not allow requests for search results after the first 500Louise Crow2015-02-03-0/+6
| | | | | | | The pages for these search results are extremely slow to load. This is not an ideal solution by any means. Really we want to dig into why high offsets are so slow, and whether there's anything we can do to fix that.
* Sanitize the blog contents0.20.0.2Louise Crow2014-12-22-1/+13
|
* Sanitize the contents of HTML attachments before displayLouise Crow2014-12-22-0/+32
|
* Merge branch '2000-validate-category-description' into rails-3-developLouise Crow2014-12-01-0/+6
|\
| * Validate the presence of the description.Louise Crow2014-12-01-0/+6
| | | | | | | | It's required in [PublicBody#type_of_authority]( https://github.com/mysociety/alaveteli/blob/rails-3-develop/app/models/public_body.rb#L343-L347)
* | Merge branch '1965-censor-rule-creation-failure' into rails-3-developLouise Crow2014-12-01-0/+503
|\ \ | |/ |/|
| * Use instance variable for CensorRule in #destroyGareth Rees2014-11-19-2/+1
| | | | | | | | | | | | Easier to check against the assigned variable, but the spec still fails because an internal error is raised if the rule is not associated with a User or InfoRequest
| * Set the form URL to POST to in #createGareth Rees2014-11-19-0/+17
| | | | | | | | | | | | Direct the (re-rendered) form at the correct route for the association (or use the generic route if the rule is being created for some other reason)
| * Associate censor rule with something in #createGareth Rees2014-11-19-0/+48
| | | | | | | | | | Build the CensorRule against the object that is found by an additional parameter (either :info_request_id or :user_id)
| * Set the form URL to POST to in #newGareth Rees2014-11-19-0/+17
| | | | | | | | | | Direct the form at the correct route for the association (or use the generic route if the rule is being created for some other reason)
| * Associate censor rule with something in #newGareth Rees2014-11-19-0/+12
| | | | | | | | | | Build the CensorRule against the object that is found by an additional parameter (either :info_request_id or :user_id)
| * Initialize a new CensorRule in #newGareth Rees2014-11-19-0/+5
| |
| * Specs for AdminCensorRuleController#updateGareth Rees2014-11-19-0/+126
| | | | | | | | | | Note that these specs describe what the system does – not what it _should_ do!
| * Specs for AdminCensorRuleController#createGareth Rees2014-11-19-0/+111
| | | | | | | | | | Note that these specs describe what the system does – not what it _should_ do!
| * Specs for AdminCensorRuleController#destroyGareth Rees2014-11-18-0/+65
| | | | | | | | Note that these specs describe what the system does – not what it _should_ do!
| * Specs for AdminCensorRuleController#editGareth Rees2014-11-18-0/+23
| |
| * Specs for AdminCensorRuleController#newGareth Rees2014-11-18-0/+48
| |
| * Add CensorRule factoriesGareth Rees2014-11-18-0/+32
| |
* | Merge branch 'issues/1969-inconsistent-public-body-admin-interface' into ↵Gareth Rees2014-11-19-7/+16
|\ \ | | | | | | | | | rails-3-develop
| * | Remove restricton on deleting PublicBodyHeadings with associated ↵lizconlan2014-11-19-3/+6
| | | | | | | | | | | | PublicBodyCategories
| * | Fix view bug preventing PublicBodyCategories being deleted in the admin ↵lizconlan2014-11-19-4/+10
| | | | | | | | | | | | interface
* | | Remove stubs of removed methodGareth Rees2014-11-18-5/+0
| |/ |/| | | | | | | | | | | PublicBodyCategory#load_categories no longer exists, so don't try to stub it. Fixes https://github.com/mysociety/alaveteli/issues/1970
* | Use flash[:error] for error conditionGareth Rees2014-11-18-1/+3
| | | | | | Also use double quotes rather than string escaping
* | Add specs to cover unsuccessful creationGareth Rees2014-11-17-1/+12
| |
* | Add coverage to ensure ‘new’ templates are renderedGareth Rees2014-11-17-0/+11
| |
* | Add expectation to #index specGareth Rees2014-11-17-0/+1
| | | | | | | | The spec that covers AdminPublicBodyCategoriesController#index did not have an expectation
* | Redirect to #edit after updatingGareth Rees2014-11-17-0/+14
| | | | | | | | | | On an unsuccessful update AdminPublicBodyHeadingsController and AdminPublicBodyCategoriesController #update should render the #edit action.
* | Redirect to #edit after updatingGareth Rees2014-11-17-0/+16
| | | | | | | | | | | | | | On a successful update AdminPublicBodyHeadingsController and AdminPublicBodyCategoriesController #update should redirect to the #edit action rather than simply rendering the ‘edit’ template. Fixes https://github.com/mysociety/alaveteli/issues/1977
* | Provide expectations for controller specsGareth Rees2014-11-17-4/+17
|/ | | | This commit adds expectations to AdminPublicBodyCategoriesController and AdminPublicBodyHeadingsController edit actions
* Merge branch 'issues/1437-apple-mail-attachment-parsing' into rails-3-developGareth Rees2014-11-10-0/+13962
|\
| * Add fix for Apple Mail with attachments Gareth Rees2014-11-04-0/+13817
| |
| * Add some specs to MailBackendGareth Rees2014-11-04-0/+145
| |
* | Redirect /help to /help/aboutGareth Rees2014-11-05-0/+9
|/ | | | Shouldn't really 404 on an important/accessible URL
* Merge branch 'hotfix/0.19.0.9' into rails-3-developLouise Crow2014-10-31-6/+9
|\
| * Comment out spec which sends an invalid utf-8 param.0.19.0.9hotfix/0.19.0.9Louise Crow2014-10-31-6/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The original error `ActionView::Template::Error` that this spec was written to represent (#1406) occurred under ruby 1.8 when the decoded non-utf-8 string was used in the locale switcher on the 'not found' error page to generate a url for the alternative locales. Under Ruby >= 1.9, the error thrown in that situation is an `invalid byte sequence in UTF-8` error, thrown in the same place - the locale switcher. However, no error seems to be thrown when the same param is used in a request in production. The upgrade to Rails 3.2.20 causes `String.split` to be called on the request path in `actionpack/lib/action_dispatch/middleware/static.rb` in order to check for attempts to access files outside the `public` directory. This means that under Ruby >= 1.9, an `invalid byte sequence in UTF-8` error will be thrown there in running this spec. I think a possible solution is to use the `rack-utf8_sanitizer` gem to provide middleware to strip invalid utf-8 from request URIs and headers before they're processed by Rails, but it's currently unclear whether that would have any undesirable side-effects.
* | Merge branch 'issues/1457-close-change-request-without-email' into ↵Louise Crow2014-10-30-16/+26
|\ \ | | | | | | | | | rails-3-develop
| * | Remove redirect to trailing slash URL.Louise Crow2014-10-30-6/+1
| | | | | | | | | | | | | | | Introduced in 4f501309ade230f65f4ba45e1d0161e89587d755 but no longer needed as we don't proxy the admin interface.
| * | Allow closure of a change request without sending an email.Louise Crow2014-10-30-10/+25
| |/
* | Merge branch 'code_tidying' into rails-3-developGareth Rees2014-10-29-0/+124
|\ \
| * | Add ChangeEmailValidator specGareth Rees2014-10-29-0/+124
| | |
* | | Merge branch 'fix_transient_locale_integration_errors' into rails-3-developLouise Crow2014-10-28-7/+22
|\ \ \ | |/ / |/| |
| * | Use factories, not fixtures, in integration spec.Louise Crow2014-10-28-7/+22
| | | | | | | | | | | | Removes the dependency on fixtures having been loaded.
* | | Merge branch 'issues/1778-send-message' into rails-3-developGareth Rees2014-10-17-7/+34
|\ \ \
| * | | Remove now-unused OutgoingMessage#send_messageGareth Rees2014-10-17-4/+7
| | | | | | | | | | | | | | | | Models should not send emails
| * | | Extract initial and followup sending from modelGareth Rees2014-10-17-3/+27
| | | |
* | | | Merge branch 'spam_address_routing' into rails-3-developGareth Rees2014-10-14-2/+2
|\ \ \ \
| * | | | Add admin prefix to spam_addresses resourcesGareth Rees2014-10-10-2/+2
| |/ / /
* | | | Merge branch 'issues/1830-batch-request-user-filter' into rails-3-developGareth Rees2014-10-14-2/+14
|\ \ \ \ | |_|/ / |/| | |
| * | | User profile option to filter requests by statusGareth Rees2014-10-14-2/+14
| |/ / | | | | | | | | | | | | Filters on `latest_status` because filtering by `status` searches all states a request has ever been in.
* | | Merge branch 'issues/222-category-editing-add-order-interface' into ↵Louise Crow2014-10-14-57/+733
|\ \ \ | |/ / |/| | | | | rails-3-develop
generated by cgit v1.2.3 (git 2.25.1) at 2025-08-05 19:41:37 +0000