From ef97ebe2b9b12f5c44a9382b7a81cfca765c1696 Mon Sep 17 00:00:00 2001 From: James McKinney Date: Thu, 21 May 2015 14:15:30 +0200 Subject: Avoid unnecessary ternary operations --- app/controllers/user_controller.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'app/controllers/user_controller.rb') diff --git a/app/controllers/user_controller.rb b/app/controllers/user_controller.rb index 91eb7baf4..e23649a1f 100644 --- a/app/controllers/user_controller.rb +++ b/app/controllers/user_controller.rb @@ -177,7 +177,7 @@ class UserController < ApplicationController return else if !@post_redirect.nil? - @user_signin = User.authenticate_from_form(params[:user_signin], @post_redirect.reason_params[:user_name] ? true : false) + @user_signin = User.authenticate_from_form(params[:user_signin], @post_redirect.reason_params[:user_name]) end if @post_redirect.nil? || @user_signin.errors.size > 0 # Failed to authenticate @@ -188,7 +188,7 @@ class UserController < ApplicationController if @user_signin.email_confirmed session[:user_id] = @user_signin.id session[:user_circumstance] = nil - session[:remember_me] = params[:remember_me] ? true : false + session[:remember_me] = !!params[:remember_me] if is_modal_dialog render :action => 'signin_successful' -- cgit v1.2.3 From d8da040dce219f66e7788bddf645ce9c9aa017f4 Mon Sep 17 00:00:00 2001 From: James McKinney Date: Wed, 27 May 2015 16:34:52 -0400 Subject: Eliminate !! (bang bang) --- app/controllers/user_controller.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'app/controllers/user_controller.rb') diff --git a/app/controllers/user_controller.rb b/app/controllers/user_controller.rb index e23649a1f..8d9adfc77 100644 --- a/app/controllers/user_controller.rb +++ b/app/controllers/user_controller.rb @@ -188,7 +188,7 @@ class UserController < ApplicationController if @user_signin.email_confirmed session[:user_id] = @user_signin.id session[:user_circumstance] = nil - session[:remember_me] = !!params[:remember_me] + session[:remember_me] = params[:remember_me] ? true : false if is_modal_dialog render :action => 'signin_successful' -- cgit v1.2.3