From b62d81b80016c9046e19fb10e28c07a5514b3095 Mon Sep 17 00:00:00 2001 From: Gareth Rees Date: Tue, 21 Apr 2015 16:07:35 +0100 Subject: Only load the outgoing messages that will be used Prevents loading of all outgoing messages related to the info request. Before OutgoingMessage Load (1.5ms) SELECT "outgoing_messages".* FROM "outgoing_messages" WHERE "outgoing_messages"."info_request_id" = 137 ORDER BY created_at After OutgoingMessage Load (0.8ms) SELECT "outgoing_messages".* FROM "outgoing_messages" WHERE "outgoing_messages"."info_request_id" = 137 ORDER BY created_at LIMIT 1 --- app/models/info_request.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'app/models/info_request.rb') diff --git a/app/models/info_request.rb b/app/models/info_request.rb index fd42ccd9c..b09f60d40 100644 --- a/app/models/info_request.rb +++ b/app/models/info_request.rb @@ -806,7 +806,7 @@ public if outgoing_messages.empty? # mainly for use with incomplete fixtures return "" end - excerpt = self.outgoing_messages[0].get_text_for_indexing + excerpt = self.outgoing_messages.first.get_text_for_indexing return excerpt end -- cgit v1.2.3 From 2a58f4995472893257f55aab03a1899af891e941 Mon Sep 17 00:00:00 2001 From: Gareth Rees Date: Tue, 21 Apr 2015 16:09:52 +0100 Subject: Tidy InfoRequest#initial_request_text --- app/models/info_request.rb | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'app/models/info_request.rb') diff --git a/app/models/info_request.rb b/app/models/info_request.rb index b09f60d40..245de1e15 100644 --- a/app/models/info_request.rb +++ b/app/models/info_request.rb @@ -803,11 +803,8 @@ public # Text from the the initial request, for use in summary display def initial_request_text - if outgoing_messages.empty? # mainly for use with incomplete fixtures - return "" - end - excerpt = self.outgoing_messages.first.get_text_for_indexing - return excerpt + return '' if outgoing_messages.empty? # mainly for use with incomplete fixtures + outgoing_messages.first.get_text_for_indexing end # Returns index of last event which is described or nil if none described. -- cgit v1.2.3