From 66279a9373226f49d0c47ab651f61deb2aebf1a7 Mon Sep 17 00:00:00 2001 From: Matthew Landauer Date: Fri, 1 Mar 2013 14:54:09 +1100 Subject: Simplify logic in method --- app/models/info_request.rb | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) (limited to 'app/models/info_request.rb') diff --git a/app/models/info_request.rb b/app/models/info_request.rb index f7391a60a..e0ade0eb6 100644 --- a/app/models/info_request.rb +++ b/app/models/info_request.rb @@ -972,13 +972,8 @@ public end def is_old_unclassified? - return false if is_external? - return false if !awaiting_description - return false if url_title == 'holding_pen' - last_response_event = get_last_response_event - return false unless last_response_event - return false if last_response_event.created_at >= Time.now - OLD_AGE_IN_DAYS - return true + !is_external? && awaiting_description && url_title != 'holding_pen' && get_last_response_event && + Time.now > get_last_response_event.created_at + OLD_AGE_IN_DAYS end # List of incoming messages to followup, by unique email -- cgit v1.2.3