From 99457f15722b3326ba11ecb3003c3dd50b70a9c4 Mon Sep 17 00:00:00 2001 From: Robin Houston Date: Mon, 20 Aug 2012 08:00:03 +0100 Subject: Fix tests Also make the InfoRequest#is_old_unclassified? method a little more conservative, by returning false only is the is_external? method returns true. This makes it subtly inconsistent with InfoRequest.find_old_unclassified, but it is better I think to be subtly inconsistent than to risk breaking things that used to work. --- app/models/info_request.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'app/models/info_request.rb') diff --git a/app/models/info_request.rb b/app/models/info_request.rb index 6426f6ea8..e88c3a95f 100644 --- a/app/models/info_request.rb +++ b/app/models/info_request.rb @@ -960,7 +960,7 @@ public end def is_old_unclassified? - return false if user_id.nil? + return false if is_external? return false if !awaiting_description return false if url_title == 'holding_pen' last_response_event = get_last_response_event -- cgit v1.2.3