From a176da3b7611153421fc6a33bb502297ae50a0e2 Mon Sep 17 00:00:00 2001 From: Louise Crow Date: Mon, 16 Sep 2013 12:55:39 +0100 Subject: Use 403, not 410, for hidden items. As @mhl points out, this more clearly indicates that they may come back at some point. --- spec/controllers/request_controller_spec.rb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'spec/controllers/request_controller_spec.rb') diff --git a/spec/controllers/request_controller_spec.rb b/spec/controllers/request_controller_spec.rb index 854ce09c6..d324670c4 100644 --- a/spec/controllers/request_controller_spec.rb +++ b/spec/controllers/request_controller_spec.rb @@ -776,7 +776,7 @@ describe RequestController, "when handling prominence" do def expect_hidden(hidden_template) response.content_type.should == "text/html" response.should render_template(hidden_template) - response.code.should == '410' + response.code.should == '403' end context 'when the request is hidden' do @@ -800,7 +800,7 @@ describe RequestController, "when handling prominence" do it 'should not show request if requested using json' do session[:user_id] = @info_request.user.id get :show, :url_title => @info_request.url_title, :format => 'json' - response.code.should == '410' + response.code.should == '403' end it "should show request if logged in as super user" do @@ -1319,12 +1319,12 @@ describe RequestController, "when viewing an individual response for reply/follo response.should render_template('request/hidden') end - it 'should respond to a json request for a hidden request with a 410 code and no body' do + it 'should respond to a json request for a hidden request with a 403 code and no body' do get :show_response, :id => info_requests(:fancy_dog_request).id, :incoming_message_id => incoming_messages(:useless_incoming_message), :format => 'json' - response.code.should == '410' + response.code.should == '403' end end -- cgit v1.2.3