From 44eff43ee8024a03fe4c327638ac0dbc1b47f4fd Mon Sep 17 00:00:00 2001 From: Gareth Rees Date: Wed, 2 Apr 2014 11:31:55 +0100 Subject: Simpler AttachmentToHTML::Adapters::Text interface --- spec/lib/attachment_to_html/adapters/text_spec.rb | 95 ++++++----------------- 1 file changed, 22 insertions(+), 73 deletions(-) (limited to 'spec/lib/attachment_to_html') diff --git a/spec/lib/attachment_to_html/adapters/text_spec.rb b/spec/lib/attachment_to_html/adapters/text_spec.rb index 599670603..b2e8141e0 100644 --- a/spec/lib/attachment_to_html/adapters/text_spec.rb +++ b/spec/lib/attachment_to_html/adapters/text_spec.rb @@ -3,93 +3,47 @@ require File.expand_path(File.dirname(__FILE__) + '/../../../spec_helper') describe AttachmentToHTML::Adapters::Text do let(:attachment) { FactoryGirl.build(:body_text) } - let(:text_adapter) { AttachmentToHTML::Adapters::Text.new(attachment) } + let(:adapter) { AttachmentToHTML::Adapters::Text.new(attachment) } - describe :wrapper do + describe :title do - it 'defaults to wrapper' do - text_adapter.wrapper.should == 'wrapper' - end - - it 'accepts a wrapper option' do - text_adapter = AttachmentToHTML::Adapters::Text.new(attachment, :wrapper => 'wrap') - text_adapter.wrapper.should == 'wrap' + it 'uses the attachment filename for the title' do + adapter.title.should == attachment.display_filename end end - describe :to_html do - - it 'should be a valid html document' do - parsed = Nokogiri::HTML.parse(text_adapter.to_html) do |config| - config.strict - end - parsed.errors.any?.should be_false - end - - it 'contains the attachment filename in the title tag' do - parsed = Nokogiri::HTML.parse(text_adapter.to_html) do |config| - config.strict - end - parsed.css('title').inner_html.should == attachment.display_filename - end + describe :body do - it 'contains the wrapper div in the body tag' do - text_adapter = AttachmentToHTML::Adapters::Text.new(attachment, :wrapper => 'wrap') - parsed = Nokogiri::HTML.parse(text_adapter.to_html) do |config| - config.strict - end - parsed.css('body').children.first.attributes['id'].value.should == 'wrap' + it 'extracts the body from the document' do + adapter.body.should == attachment.body end - it 'contains the attachment body in the wrapper div' do - text_adapter = AttachmentToHTML::Adapters::Text.new(attachment, :wrapper => 'wrap') - parsed = Nokogiri::HTML.parse(text_adapter.to_html) do |config| - config.strict - end - parsed.css('div#wrap div#view-html-content').inner_html.should == attachment.body - end - it 'strips the body of trailing whitespace' do attachment = FactoryGirl.build(:body_text, :body => ' Hello ') - text_adapter = AttachmentToHTML::Adapters::Text.new(attachment) - parsed = Nokogiri::HTML.parse(text_adapter.to_html) do |config| - config.strict - end - parsed.css('div#wrapper div#view-html-content').inner_html.should == 'Hello' + adapter = AttachmentToHTML::Adapters::Text.new(attachment) + adapter.body.should == 'Hello' end - # NOTE: Can't parse this spec with Nokogiri at the moment because even - # in strict mode Nokogiri tampers with the HTML returned: - # Failure/Error: parsed.css('div#wrapper div#view-html-content'). - # inner_html.should == expected - # expected: "Usage: foo "bar" >baz<" - # got: "Usage: foo \"bar\" >baz<" (using ==) it 'escapes special characters' do attachment = FactoryGirl.build(:body_text, :body => 'Usage: foo "bar" >baz<') - text_adapter = AttachmentToHTML::Adapters::Text.new(attachment) + adapter = AttachmentToHTML::Adapters::Text.new(attachment) expected = %Q(Usage: foo "bar" >baz<) - text_adapter.to_html.should include(expected) + adapter.body.should == expected end it 'creates hyperlinks for text that looks like a url' do attachment = FactoryGirl.build(:body_text, :body => 'http://www.whatdotheyknow.com') - text_adapter = AttachmentToHTML::Adapters::Text.new(attachment) - parsed = Nokogiri::HTML.parse(text_adapter.to_html) do |config| - config.strict - end - parsed.css('div#wrapper div#view-html-content a').first.text.should == 'http://www.whatdotheyknow.com' - parsed.css('div#wrapper div#view-html-content a').first['href'].should == 'http://www.whatdotheyknow.com' + adapter = AttachmentToHTML::Adapters::Text.new(attachment) + expected = %Q(http://www.whatdotheyknow.com) + adapter.body.should == expected end it 'substitutes newlines for br tags' do attachment = FactoryGirl.build(:body_text, :body => "A\nNewline") - text_adapter = AttachmentToHTML::Adapters::Text.new(attachment) - parsed = Nokogiri::HTML.parse(text_adapter.to_html) do |config| - config.strict - end + adapter = AttachmentToHTML::Adapters::Text.new(attachment) expected = %Q(A
Newline) - parsed.css('div#wrapper div#view-html-content').inner_html.should == expected + adapter.body.should == expected end end @@ -97,23 +51,18 @@ describe AttachmentToHTML::Adapters::Text do describe :success? do it 'is successful if the body has content excluding the tags' do - text_adapter.to_html - text_adapter.success?.should be_true + adapter.stub(:body).and_return('

some content

') + adapter.success?.should be_true end it 'is successful if the body contains images' do - mocked_return = %Q() - text_adapter = AttachmentToHTML::Adapters::Text.new(attachment) - text_adapter.stub(:to_html).and_return(mocked_return) - text_adapter.success?.should be_true + adapter.stub(:body).and_return(%Q()) + adapter.success?.should be_true end it 'is not successful if the body has no content other than tags' do - empty_txt = load_file_fixture('empty.txt') - attachment = FactoryGirl.build(:body_text, :body => empty_txt) - text_adapter = AttachmentToHTML::Adapters::Text.new(attachment) - text_adapter.to_html - text_adapter.success?.should be_false + adapter.stub(:body).and_return('

') + adapter.success?.should be_false end end -- cgit v1.2.3