From e5dd06bb90b28b14b9a476d999d22ca345dabf07 Mon Sep 17 00:00:00 2001 From: Matthew Landauer Date: Thu, 11 Oct 2012 10:09:21 +1100 Subject: Rename models and tables exim -> mail_server --- spec/models/mail_server_log_spec.rb | 137 ++++++++++++++++++++++++++++++++++++ 1 file changed, 137 insertions(+) create mode 100644 spec/models/mail_server_log_spec.rb (limited to 'spec/models/mail_server_log_spec.rb') diff --git a/spec/models/mail_server_log_spec.rb b/spec/models/mail_server_log_spec.rb new file mode 100644 index 000000000..cad64f7ff --- /dev/null +++ b/spec/models/mail_server_log_spec.rb @@ -0,0 +1,137 @@ +require File.expand_path(File.dirname(__FILE__) + '/../spec_helper') + +describe MailServerLog do + describe ".load_file" do + before :each do + Configuration.stub!(:incoming_email_domain).and_return("example.com") + File.stub_chain(:stat, :mtime).and_return(DateTime.new(2012, 10, 10)) + end + + let(:log) {[ + "This is a line of a logfile relevant to foi+request-1234@example.com", + "This is the second line for the same foi+request-1234@example.com email address" + ]} + + let(:ir) { info_requests(:fancy_dog_request) } + + it "loads relevant lines of an uncompressed exim log file" do + File.should_receive(:open).with("/var/log/exim4/exim-mainlog-2012-10-10", "r").and_return(log) + InfoRequest.should_receive(:find_by_incoming_email).with("request-1234@example.com").twice.and_return(ir) + MailServerLog.load_file("/var/log/exim4/exim-mainlog-2012-10-10") + + ir.mail_server_logs.count.should == 2 + log = ir.mail_server_logs[0] + log.order.should == 1 + log.line.should == "This is a line of a logfile relevant to foi+request-1234@example.com" + + log = ir.mail_server_logs[1] + log.order.should == 2 + log.line.should == "This is the second line for the same foi+request-1234@example.com email address" + end + + it "doesn't load the log file twice if it's unchanged" do + File.should_receive(:open).with("/var/log/exim4/exim-mainlog-2012-10-10", "r").once.and_return([]) + + MailServerLog.load_file("/var/log/exim4/exim-mainlog-2012-10-10") + MailServerLog.load_file("/var/log/exim4/exim-mainlog-2012-10-10") + end + + it "loads the log file again if it's changed" do + File.should_receive(:open).with("/var/log/exim4/exim-mainlog-2012-10-10", "r").twice.and_return([]) + MailServerLog.load_file("/var/log/exim4/exim-mainlog-2012-10-10") + File.stub_chain(:stat, :mtime).and_return(DateTime.new(2012, 10, 11)) + MailServerLog.load_file("/var/log/exim4/exim-mainlog-2012-10-10") + end + + it "doesn't end up with two copies of each line when the same file is actually loaded twice" do + File.should_receive(:open).with("/var/log/exim4/exim-mainlog-2012-10-10", "r").twice.and_return(log) + InfoRequest.should_receive(:find_by_incoming_email).with("request-1234@example.com").any_number_of_times.and_return(ir) + + MailServerLog.load_file("/var/log/exim4/exim-mainlog-2012-10-10") + ir.mail_server_logs.count.should == 2 + + File.stub_chain(:stat, :mtime).and_return(DateTime.new(2012, 10, 11)) + MailServerLog.load_file("/var/log/exim4/exim-mainlog-2012-10-10") + ir.mail_server_logs.count.should == 2 + end + + it "easily handles gzip compress log files" do + File.should_not_receive(:open) + Zlib::GzipReader.should_receive(:open).with("/var/log/exim4/exim-mainlog-2012-10-10.gz").and_return([]) + MailServerLog.load_file("/var/log/exim4/exim-mainlog-2012-10-10.gz") + end + end + + context "Postfix" do + let(:log) {[ +"Oct 3 16:39:35 host postfix/pickup[2257]: CB55836EE58C: uid=1003 from=", +"Oct 3 16:39:35 host postfix/cleanup[7674]: CB55836EE58C: message-id=", +"Oct 3 16:39:35 host postfix/qmgr[1673]: 9634B16F7F7: from=, size=368, nrcpt=1 (queue active)", +"Oct 3 16:39:35 host postfix/qmgr[15615]: CB55836EE58C: from=, size=1695, nrcpt=1 (queue active)", +"Oct 3 16:39:38 host postfix/smtp[7676]: CB55836EE58C: to=, relay=aspmx.l.google.com[74.125.25.27]:25, delay=2.5, delays=0.13/0.02/1.7/0.59, dsn=2.0.0, status=sent (250 2.0.0 OK 1349246383 j9si1676296paw.328)", +"Oct 3 16:39:38 host postfix/smtp[1681]: 9634B16F7F7: to=, relay=none, delay=46, status=deferred (connect to 216.150.150.131[216.150.150.131]: No route to host)", +"Oct 3 16:39:38 host postfix/qmgr[15615]: CB55836EE58C: removed", + ]} + + describe ".load_postfix_log_data" do + # Postfix logs for a single email go over multiple lines. They are all tied together with the Queue ID. + # See http://onlamp.com/onlamp/2004/01/22/postfix.html + it "loads the postfix log and untangles seperate email transactions using the queue ID" do + Configuration.stub!(:incoming_email_domain).and_return("example.com") + log.stub!(:rewind) + ir1 = info_requests(:fancy_dog_request) + ir2 = info_requests(:naughty_chicken_request) + InfoRequest.should_receive(:find_by_incoming_email).with("request-14-e0e09f97@example.com").any_number_of_times.and_return(ir1) + InfoRequest.should_receive(:find_by_incoming_email).with("request-10-1234@example.com").any_number_of_times.and_return(ir2) + MailServerLog.load_postfix_log_data(log, MailServerLogDone.new(:filename => "foo", :last_stat => DateTime.now)) + # TODO: Check that each log line is attached to the correct request + ir1.mail_server_logs.count.should == 5 + ir1.mail_server_logs[0].order.should == 1 + ir1.mail_server_logs[0].line.should == "Oct 3 16:39:35 host postfix/pickup[2257]: CB55836EE58C: uid=1003 from=" + ir1.mail_server_logs[1].order.should == 2 + ir1.mail_server_logs[1].line.should == "Oct 3 16:39:35 host postfix/cleanup[7674]: CB55836EE58C: message-id=" + ir1.mail_server_logs[2].order.should == 4 + ir1.mail_server_logs[2].line.should == "Oct 3 16:39:35 host postfix/qmgr[15615]: CB55836EE58C: from=, size=1695, nrcpt=1 (queue active)" + ir1.mail_server_logs[3].order.should == 5 + ir1.mail_server_logs[3].line.should == "Oct 3 16:39:38 host postfix/smtp[7676]: CB55836EE58C: to=, relay=aspmx.l.google.com[74.125.25.27]:25, delay=2.5, delays=0.13/0.02/1.7/0.59, dsn=2.0.0, status=sent (250 2.0.0 OK 1349246383 j9si1676296paw.328)" + ir1.mail_server_logs[4].order.should == 7 + ir1.mail_server_logs[4].line.should == "Oct 3 16:39:38 host postfix/qmgr[15615]: CB55836EE58C: removed" + ir2.mail_server_logs.count.should == 2 + ir2.mail_server_logs[0].order.should == 3 + ir2.mail_server_logs[0].line.should == "Oct 3 16:39:35 host postfix/qmgr[1673]: 9634B16F7F7: from=, size=368, nrcpt=1 (queue active)" + ir2.mail_server_logs[1].order.should == 6 + ir2.mail_server_logs[1].line.should == "Oct 3 16:39:38 host postfix/smtp[1681]: 9634B16F7F7: to=, relay=none, delay=46, status=deferred (connect to 216.150.150.131[216.150.150.131]: No route to host)" + end + end + + describe ".scan_for_postfix_queue_ids" do + it "returns the queue ids of interest with the connected email addresses" do + Configuration.stub!(:incoming_email_domain).and_return("example.com") + MailServerLog.scan_for_postfix_queue_ids(log).should == { + "CB55836EE58C" => ["request-14-e0e09f97@example.com"], + "9634B16F7F7" => ["request-10-1234@example.com"] + } + end + end + + describe ".extract_postfix_queue_id_from_syslog_line" do + it "returns nil if there is no queue id" do + MailServerLog.extract_postfix_queue_id_from_syslog_line("Oct 7 07:16:48 kedumba postfix/smtp[14294]: connect to mail.neilcopp.com.au[110.142.151.66]:25: Connection refused").should be_nil + end + end + + describe ".request_postfix_sent?" do + it "returns true when the logs say the message was sent" do + ir = info_requests(:fancy_dog_request) + ir.mail_server_logs.create!(:line => "Oct 10 16:58:38 kedumba postfix/smtp[26358]: A664436F218D: to=, relay=aspmx.l.google.com[74.125.25.26]:25, delay=2.7, delays=0.16/0.02/1.8/0.67, dsn=2.0.0, status=sent (250 2.0.0 OK 1349848723 e6si653316paw.346)", :order => 1) + MailServerLog.request_postfix_sent?(ir).should be_true + end + + it "returns false when the logs say the message hasn't been sent" do + ir = info_requests(:fancy_dog_request) + ir.mail_server_logs.create!(:line => "Oct 10 13:22:49 kedumba postfix/smtp[11876]: 6FB9036F1307: to=, relay=mta7.am0.yahoodns.net[74.6.136.244]:25, delay=1.5, delays=0.03/0/0.48/1, dsn=5.0.0, status=bounced (host mta7.am0.yahoodns.net[74.6.136.244] said: 554 delivery error: dd Sorry your message to foo@example.com cannot be delivered. This account has been disabled or discontinued [#102]. - mta1272.mail.sk1.yahoo.com (in reply to end of DATA command))", :order => 1) + MailServerLog.request_postfix_sent?(ir).should be_false + end + end + end +end -- cgit v1.2.3 From 23f9e3fe84e33234cdec8f61775a847a23f92a2f Mon Sep 17 00:00:00 2001 From: Matthew Landauer Date: Thu, 11 Oct 2012 12:39:46 +1100 Subject: Added tests for MailServerLog.email_addresses_on_line --- spec/models/mail_server_log_spec.rb | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) (limited to 'spec/models/mail_server_log_spec.rb') diff --git a/spec/models/mail_server_log_spec.rb b/spec/models/mail_server_log_spec.rb index cad64f7ff..f4de7ee68 100644 --- a/spec/models/mail_server_log_spec.rb +++ b/spec/models/mail_server_log_spec.rb @@ -62,6 +62,26 @@ describe MailServerLog do end end + describe ".email_addresses_on_line" do + before :each do + Configuration.stub!(:incoming_email_domain).and_return("example.com") + end + + it "recognises a single incoming email" do + MailServerLog.email_addresses_on_line("a random log line foi+request-14-e0e09f97@example.com has an email").should == + ["request-14-e0e09f97@example.com"] + end + + it "recognises two email addresses on the same line" do + MailServerLog.email_addresses_on_line("two email addresses here foi+request-10-1234@example.com and foi+request-14-e0e09f97@example.com").should == + ["request-10-1234@example.com", "request-14-e0e09f97@example.com"] + end + + it "returns an empty array when there is an email address from a different domain" do + MailServerLog.email_addresses_on_line("other foi+request-10-1234@foo.com").should be_empty + end + end + context "Postfix" do let(:log) {[ "Oct 3 16:39:35 host postfix/pickup[2257]: CB55836EE58C: uid=1003 from=", -- cgit v1.2.3 From 14d84bd536883b2f10ed5c6ff4aaec4edfd17b0f Mon Sep 17 00:00:00 2001 From: Matthew Landauer Date: Thu, 11 Oct 2012 12:51:31 +1100 Subject: Ignore emails in logs with incorrect prefixes --- spec/models/mail_server_log_spec.rb | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) (limited to 'spec/models/mail_server_log_spec.rb') diff --git a/spec/models/mail_server_log_spec.rb b/spec/models/mail_server_log_spec.rb index f4de7ee68..3f87b76f1 100644 --- a/spec/models/mail_server_log_spec.rb +++ b/spec/models/mail_server_log_spec.rb @@ -65,21 +65,26 @@ describe MailServerLog do describe ".email_addresses_on_line" do before :each do Configuration.stub!(:incoming_email_domain).and_return("example.com") + Configuration.stub!(:incoming_email_prefix).and_return("foi+") end it "recognises a single incoming email" do MailServerLog.email_addresses_on_line("a random log line foi+request-14-e0e09f97@example.com has an email").should == - ["request-14-e0e09f97@example.com"] + ["foi+request-14-e0e09f97@example.com"] end it "recognises two email addresses on the same line" do MailServerLog.email_addresses_on_line("two email addresses here foi+request-10-1234@example.com and foi+request-14-e0e09f97@example.com").should == - ["request-10-1234@example.com", "request-14-e0e09f97@example.com"] + ["foi+request-10-1234@example.com", "foi+request-14-e0e09f97@example.com"] end it "returns an empty array when there is an email address from a different domain" do MailServerLog.email_addresses_on_line("other foi+request-10-1234@foo.com").should be_empty end + + it "ignores an email with a different prefix" do + MailServerLog.email_addresses_on_line("foitest+request-14-e0e09f97@example.com").should be_empty + end end context "Postfix" do -- cgit v1.2.3 From 7587537cf37e965fb190fc2ac31fa9f40c7cf117 Mon Sep 17 00:00:00 2001 From: Matthew Landauer Date: Thu, 11 Oct 2012 13:06:30 +1100 Subject: Fix small bug where email domain wasn't being quoted in the regular expression --- spec/models/mail_server_log_spec.rb | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'spec/models/mail_server_log_spec.rb') diff --git a/spec/models/mail_server_log_spec.rb b/spec/models/mail_server_log_spec.rb index 3f87b76f1..d0a1d202f 100644 --- a/spec/models/mail_server_log_spec.rb +++ b/spec/models/mail_server_log_spec.rb @@ -85,6 +85,10 @@ describe MailServerLog do it "ignores an email with a different prefix" do MailServerLog.email_addresses_on_line("foitest+request-14-e0e09f97@example.com").should be_empty end + + it "ignores an email where the . is substituted for something else" do + MailServerLog.email_addresses_on_line("foi+request-14-e0e09f97@exampledcom").should be_empty + end end context "Postfix" do -- cgit v1.2.3 From 9ae51d5ff6a9f56fd1bd4ba4bdd84bfd43ac6d95 Mon Sep 17 00:00:00 2001 From: Matthew Landauer Date: Thu, 11 Oct 2012 13:14:53 +1100 Subject: Also allow arbitrary subdomain on email addresses picked up in the logs --- spec/models/mail_server_log_spec.rb | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'spec/models/mail_server_log_spec.rb') diff --git a/spec/models/mail_server_log_spec.rb b/spec/models/mail_server_log_spec.rb index d0a1d202f..bcd74c380 100644 --- a/spec/models/mail_server_log_spec.rb +++ b/spec/models/mail_server_log_spec.rb @@ -89,6 +89,11 @@ describe MailServerLog do it "ignores an email where the . is substituted for something else" do MailServerLog.email_addresses_on_line("foi+request-14-e0e09f97@exampledcom").should be_empty end + + it "accept emails with an arbitrary subdomain" do + MailServerLog.email_addresses_on_line("foi+request-14-e0e09f97@foo.example.com").should == + ["foi+request-14-e0e09f97@foo.example.com"] + end end context "Postfix" do -- cgit v1.2.3 From e2ab4e00cb95a63f8306893b68f87e72d3016e25 Mon Sep 17 00:00:00 2001 From: Matthew Landauer Date: Fri, 12 Oct 2012 09:18:38 +1100 Subject: Revert "Also allow arbitrary subdomain on email addresses picked up in the logs" This reverts commit 9ae51d5ff6a9f56fd1bd4ba4bdd84bfd43ac6d95. --- spec/models/mail_server_log_spec.rb | 5 ----- 1 file changed, 5 deletions(-) (limited to 'spec/models/mail_server_log_spec.rb') diff --git a/spec/models/mail_server_log_spec.rb b/spec/models/mail_server_log_spec.rb index bcd74c380..d0a1d202f 100644 --- a/spec/models/mail_server_log_spec.rb +++ b/spec/models/mail_server_log_spec.rb @@ -89,11 +89,6 @@ describe MailServerLog do it "ignores an email where the . is substituted for something else" do MailServerLog.email_addresses_on_line("foi+request-14-e0e09f97@exampledcom").should be_empty end - - it "accept emails with an arbitrary subdomain" do - MailServerLog.email_addresses_on_line("foi+request-14-e0e09f97@foo.example.com").should == - ["foi+request-14-e0e09f97@foo.example.com"] - end end context "Postfix" do -- cgit v1.2.3