1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
|
require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
describe ApiController, "when using the API" do
it "should check the API key" do
request_data = {
"title" => "Tell me about your chickens",
"body" => "Dear Sir,\n\nI should like to know about your chickens.\n\nYours in faith,\nBob\n",
"external_url" => "http://www.example.gov.uk/foi/chickens_23",
"external_user_name" => "Bob Smith",
}
number_of_requests = InfoRequest.count
expect {
post :create_request, :k => "This is not really an API key", :request_json => request_data.to_json
}.to raise_error ApplicationController::PermissionDenied
InfoRequest.count.should == number_of_requests
end
it "should create a new request from a POST" do
number_of_requests = InfoRequest.count(
:conditions => [
"public_body_id = ?",
public_bodies(:geraldine_public_body).id
]
)
request_data = {
"title" => "Tell me about your chickens",
"body" => "Dear Sir,\n\nI should like to know about your chickens.\n\nYours in faith,\nBob\n",
"external_url" => "http://www.example.gov.uk/foi/chickens_23",
"external_user_name" => "Bob Smith",
}
post :create_request, :k => public_bodies(:geraldine_public_body).api_key, :request_json => request_data.to_json
response.should be_success
response.content_type.should == "application/json"
response_body = ActiveSupport::JSON.decode(response.body)
response_body["errors"].should be_nil
response_body["url"].should =~ /^http/
InfoRequest.count(:conditions => [
"public_body_id = ?",
public_bodies(:geraldine_public_body).id]
).should == number_of_requests + 1
new_request = InfoRequest.find(response_body["id"])
new_request.user_id.should be_nil
new_request.external_user_name.should == request_data["external_user_name"]
new_request.external_url.should == request_data["external_url"]
new_request.title.should == request_data["title"]
new_request.last_event_forming_initial_request.outgoing_message.body.should == request_data["body"].strip
new_request.public_body_id.should == public_bodies(:geraldine_public_body).id
end
def _create_request
post :create_request,
:k => public_bodies(:geraldine_public_body).api_key,
:request_json => {
"title" => "Tell me about your chickens",
"body" => "Dear Sir,\n\nI should like to know about your chickens.\n\nYours in faith,\nBob\n",
"external_url" => "http://www.example.gov.uk/foi/chickens_23",
"external_user_name" => "Bob Smith",
}.to_json
response.content_type.should == "application/json"
return ActiveSupport::JSON.decode(response.body)["id"]
end
it "should add a response to a request" do
# First we need an external request
request_id = info_requests(:external_request).id
# Initially it has no incoming messages
IncomingMessage.count(:conditions => ["info_request_id = ?", request_id]).should == 0
# Now add one
sent_at = "2012-05-28T12:35:39+01:00"
response_body = "Thank you for your request for information, which we are handling in accordance with the Freedom of Information Act 2000. You will receive a response within 20 working days or before the next full moon, whichever is sooner.\n\nYours sincerely,\nJohn Gandermulch,\nExample Council FOI Officer\n"
post :add_correspondence,
:k => public_bodies(:geraldine_public_body).api_key,
:id => request_id,
:correspondence_json => {
"direction" => "response",
"sent_at" => sent_at,
"body" => response_body
}.to_json
# And make sure it worked
response.should be_success
incoming_messages = IncomingMessage.all(:conditions => ["info_request_id = ?", request_id])
incoming_messages.count.should == 1
incoming_message = incoming_messages[0]
incoming_message.sent_at.should == Time.iso8601(sent_at)
incoming_message.get_main_body_text_folded.should == response_body
end
it "should add a followup to a request" do
# First we need an external request
request_id = info_requests(:external_request).id
# Initially it has one outgoing message
OutgoingMessage.count(:conditions => ["info_request_id = ?", request_id]).should == 1
# Add another, as a followup
sent_at = "2012-05-29T12:35:39+01:00"
followup_body = "Pls answer ASAP.\nkthxbye\n"
post :add_correspondence,
:k => public_bodies(:geraldine_public_body).api_key,
:id => request_id,
:correspondence_json => {
"direction" => "request",
"sent_at" => sent_at,
"body" => followup_body
}.to_json
# Make sure it worked
response.should be_success
followup_messages = OutgoingMessage.all(
:conditions => ["info_request_id = ? and message_type = 'followup'", request_id]
)
followup_messages.size.should == 1
followup_message = followup_messages[0]
followup_message.last_sent_at.should == Time.iso8601(sent_at)
followup_message.body.should == followup_body.strip
end
it "should not allow internal requests to be updated" do
n_incoming_messages = IncomingMessage.count
n_outgoing_messages = OutgoingMessage.count
expect {
post :add_correspondence,
:k => public_bodies(:geraldine_public_body).api_key,
:id => info_requests(:naughty_chicken_request).id,
:correspondence_json => {
"direction" => "request",
"sent_at" => Time.now.iso8601,
"body" => "xxx"
}.to_json
}.to raise_error ActiveRecord::RecordNotFound
IncomingMessage.count.should == n_incoming_messages
OutgoingMessage.count.should == n_outgoing_messages
end
it "should not allow other people’s requests to be updated" do
request_id = _create_request
n_incoming_messages = IncomingMessage.count
n_outgoing_messages = OutgoingMessage.count
expect {
post :add_correspondence,
:k => public_bodies(:humpadink_public_body).api_key,
:id => request_id,
:correspondence_json => {
"direction" => "request",
"sent_at" => Time.now.iso8601,
"body" => "xxx"
}.to_json
}.to raise_error ActiveRecord::RecordNotFound
IncomingMessage.count.should == n_incoming_messages
OutgoingMessage.count.should == n_outgoing_messages
end
it "should not allow files to be attached to a followup" do
post :add_correspondence,
:k => public_bodies(:geraldine_public_body).api_key,
:id => info_requests(:external_request).id,
:correspondence_json => {
"direction" => "request",
"sent_at" => Time.now.iso8601,
"body" => "Are you joking, or are you serious?"
}.to_json,
:attachments => [
fixture_file_upload("files/tfl.pdf")
]
# Make sure it worked
response.status.to_i.should == 500
errors = ActiveSupport::JSON.decode(response.body)["errors"]
errors.should == ["You cannot attach files to messages in the 'request' direction"]
end
it "should allow files to be attached to a response" do
# First we need an external request
request_id = info_requests(:external_request).id
# Initially it has no incoming messages
IncomingMessage.count(:conditions => ["info_request_id = ?", request_id]).should == 0
# Now add one
sent_at = "2012-05-28T12:35:39+01:00"
response_body = "Thank you for your request for information, which we are handling in accordance with the Freedom of Information Act 2000. You will receive a response within 20 working days or before the next full moon, whichever is sooner.\n\nYours sincerely,\nJohn Gandermulch,\nExample Council FOI Officer\n"
post :add_correspondence,
:k => public_bodies(:geraldine_public_body).api_key,
:id => request_id,
:correspondence_json => {
"direction" => "response",
"sent_at" => sent_at,
"body" => response_body
}.to_json,
:attachments => [
fixture_file_upload("files/tfl.pdf")
]
# And make sure it worked
response.should be_success
incoming_messages = IncomingMessage.all(:conditions => ["info_request_id = ?", request_id])
incoming_messages.count.should == 1
incoming_message = incoming_messages[0]
incoming_message.sent_at.should == Time.iso8601(sent_at)
incoming_message.get_main_body_text_folded.should == response_body
# Get the attachment
attachments = incoming_message.get_attachments_for_display
attachments.size.should == 1
attachment = attachments[0]
attachment.filename.should == "tfl.pdf"
attachment.body.should == open("files/tfl.pdf", &:read)
end
it "should show information about a request" do
info_request = info_requests(:naughty_chicken_request)
get :show_request,
:k => public_bodies(:geraldine_public_body).api_key,
:id => info_request.id
response.should be_success
assigns[:request].id.should == info_request.id
r = ActiveSupport::JSON.decode(response.body)
r["title"].should == info_request.title
# Let’s not test all the fields here, because it would
# essentially just be a matter of copying the code that
# assigns them and changing assignment to an equality
# check, which does not really test anything at all.
end
end
|
