From cfbe3e5bdd94a948a046521faf9b78cf9bf54501 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?H=C3=A5kon=20Solbj=C3=B8rg?= Date: Fri, 7 Apr 2023 20:52:33 +0200 Subject: fix(mist2netbox): Remove tag again if it wasn't there --- tools/netbox/scripts/mist2netbox/mist2netbox.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/netbox/scripts/mist2netbox/mist2netbox.py b/tools/netbox/scripts/mist2netbox/mist2netbox.py index b3bb57f..75cf0b7 100644 --- a/tools/netbox/scripts/mist2netbox/mist2netbox.py +++ b/tools/netbox/scripts/mist2netbox/mist2netbox.py @@ -196,10 +196,12 @@ class Mist2Netbox(Script): device.primary_ip6 = mgmt_addr_v6 device.save() - if "locating" in device_data and device_data["locating"]: + if "locating" in device_data: locating_tag, _ = Tag.objects.get_or_create(name="locating") - device.tags.add(locating_tag) - + if device_data["locating"]: + device.tags.add(locating_tag) + else: + device.tags.remove(locating_tag) # Add tag to everything we created so it's easy to identify in case we # want to recreate -- cgit v1.2.3