aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatthew Somerville <matthew-github@dracos.co.uk>2017-08-16 18:04:41 +0100
committerMatthew Somerville <matthew-github@dracos.co.uk>2017-08-17 16:43:21 +0100
commit1d9e10e980e480196ba1a5f1a3bc450a06b78dde (patch)
treeb739300f295275bd2b586847373e7a87378cc894
parentd034f3c1447ea91cb4333365ce123d58deb2de0d (diff)
Fix replaced sidebar losing hover behaviour.
If the list was replaced by JavaScript, the event handlers were being dropped. Switch the handlers to the parent that remains present.
-rw-r--r--CHANGELOG.md1
-rw-r--r--templates/web/base/front/recent.html2
-rw-r--r--web/cobrands/fixmystreet/staff.js2
-rw-r--r--web/js/map-OpenLayers.js2
4 files changed, 4 insertions, 3 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 95886d478..0c7bf854e 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -12,6 +12,7 @@
- Extra fields on contacts can be edited. #1743
- Bugfixes:
- Set up action scheduled field when report loaded. #1789
+ - Fix sidebar hover behaviour being lost. #1808
- Stop errors from JS validator due to form in form.
- Stop update form toggle causing report submission.
- Update map size if an extra column has appeared.
diff --git a/templates/web/base/front/recent.html b/templates/web/base/front/recent.html
index cb83c51b8..1fe6ad2be 100644
--- a/templates/web/base/front/recent.html
+++ b/templates/web/base/front/recent.html
@@ -13,7 +13,7 @@
</h2>
<section class="full-width">
- <ul class="item-list item-list--reports item-list--front-page">
+ <ul id="js-reports-list" class="item-list item-list--reports item-list--front-page">
[% FOREACH problem IN recent_photos %]
[% INCLUDE 'front/_list-entry.html' %]
[% END %]
diff --git a/web/cobrands/fixmystreet/staff.js b/web/cobrands/fixmystreet/staff.js
index ec71ae20f..07a2729e2 100644
--- a/web/cobrands/fixmystreet/staff.js
+++ b/web/cobrands/fixmystreet/staff.js
@@ -93,7 +93,7 @@ $.extend(fixmystreet.set_up, {
},
list_item_actions: function() {
- $('.item-list--reports').on('click', ':submit', function(e) {
+ $('#js-reports-list').on('click', ':submit', function(e) {
e.preventDefault();
var $submitButton = $(this);
diff --git a/web/js/map-OpenLayers.js b/web/js/map-OpenLayers.js
index 53535b146..6a0d938fc 100644
--- a/web/js/map-OpenLayers.js
+++ b/web/js/map-OpenLayers.js
@@ -674,7 +674,7 @@ var fixmystreet = fixmystreet || {};
(function() {
var timeout;
- $('.item-list--reports').on('mouseenter', '.item-list--reports__item', function(){
+ $('#js-reports-list').on('mouseenter', '.item-list--reports__item', function(){
var href = $('a', this).attr('href');
var id = parseInt(href.replace(/^.*[\/]([0-9]+)$/, '$1'),10);
clearTimeout(timeout);