diff options
author | Gareth Rees <gareth@mysociety.org> | 2014-10-01 13:00:01 +0100 |
---|---|---|
committer | Louise Crow <louise.crow@gmail.com> | 2014-12-22 17:11:55 +0000 |
commit | 3b2cc4bf80d1a23450ae90f5800d024ee37172eb (patch) | |
tree | 6045380ba81e41b28b4e12cfb4aaad49567dd3bf | |
parent | 573c61ca2b9e3d69e05991aaa761fb9c6122dcab (diff) |
Fix unvalidated redirects
-rw-r--r-- | app/controllers/track_controller.rb | 2 | ||||
-rw-r--r-- | app/controllers/user_controller.rb | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/app/controllers/track_controller.rb b/app/controllers/track_controller.rb index 40fa69290..b2fa1cf04 100644 --- a/app/controllers/track_controller.rb +++ b/app/controllers/track_controller.rb @@ -215,7 +215,7 @@ class TrackController < ApplicationController end flash[:notice] += "</ul>" - redirect_to params[:r] + redirect_to URI.parse(params[:r]).path end diff --git a/app/controllers/user_controller.rb b/app/controllers/user_controller.rb index c2cc426d4..bb1415baf 100644 --- a/app/controllers/user_controller.rb +++ b/app/controllers/user_controller.rb @@ -253,7 +253,7 @@ class UserController < ApplicationController def signout self._do_signout if params[:r] - redirect_to params[:r] + redirect_to URI.parse(params[:r]).path else redirect_to :controller => "general", :action => "frontpage" end @@ -593,7 +593,7 @@ class UserController < ApplicationController end @user.receive_email_alerts = params[:receive_email_alerts] @user.save! - redirect_to params[:came_from] + redirect_to URI.parse(params[:came_from]).path end private |