aboutsummaryrefslogtreecommitdiffstats
path: root/lib/http_client.c
diff options
context:
space:
mode:
authorWilmer van der Gaast <wilmer@gaast.net>2011-12-23 13:44:08 +0100
committerWilmer van der Gaast <wilmer@gaast.net>2011-12-23 13:44:08 +0100
commit792a93b417c24a206d8995ca8bf51482f20e997e (patch)
treec29c4ceae134df4ad52e79ef50bc09d00e1b245d /lib/http_client.c
parent2d93a51e15ac2d6daaac0d6ac1e2c41e33486c53 (diff)
parent41658da57b611d17030dc7e2c3feb54f99b668ac (diff)
Merging SSL certificate verification for GnuTLS, with help from AopicieR.
Diffstat (limited to 'lib/http_client.c')
-rw-r--r--lib/http_client.c21
1 files changed, 16 insertions, 5 deletions
diff --git a/lib/http_client.c b/lib/http_client.c
index 9d986412..98a99f7c 100644
--- a/lib/http_client.c
+++ b/lib/http_client.c
@@ -32,7 +32,7 @@
static gboolean http_connected( gpointer data, int source, b_input_condition cond );
-static gboolean http_ssl_connected( gpointer data, void *source, b_input_condition cond );
+static gboolean http_ssl_connected( gpointer data, int returncode, void *source, b_input_condition cond );
static gboolean http_incoming_data( gpointer data, int source, b_input_condition cond );
static void http_free( struct http_request *req );
@@ -46,7 +46,7 @@ struct http_request *http_dorequest( char *host, int port, int ssl, char *reques
if( ssl )
{
- req->ssl = ssl_connect( host, port, http_ssl_connected, req );
+ req->ssl = ssl_connect( host, port, TRUE, http_ssl_connected, req );
if( req->ssl == NULL )
error = 1;
}
@@ -162,19 +162,30 @@ static gboolean http_connected( gpointer data, int source, b_input_condition con
return FALSE;
error:
- req->status_string = g_strdup( "Error while writing HTTP request" );
+ if( req->status_string == NULL )
+ req->status_string = g_strdup( "Error while writing HTTP request" );
req->func( req );
http_free( req );
return FALSE;
}
-static gboolean http_ssl_connected( gpointer data, void *source, b_input_condition cond )
+static gboolean http_ssl_connected( gpointer data, int returncode, void *source, b_input_condition cond )
{
struct http_request *req = data;
if( source == NULL )
+ {
+ if( returncode != 0 )
+ {
+ char *err = ssl_verify_strerror( returncode );
+ req->status_string = g_strdup_printf(
+ "Certificate verification problem 0x%x: %s",
+ returncode, err ? err : "Unknown" );
+ g_free( err );
+ }
return http_connected( data, -1, cond );
+ }
req->fd = ssl_getfd( source );
@@ -438,7 +449,7 @@ got_reply:
if( new_proto == PROTO_HTTPS )
{
- req->ssl = ssl_connect( new_host, new_port, http_ssl_connected, req );
+ req->ssl = ssl_connect( new_host, new_port, TRUE, http_ssl_connected, req );
if( req->ssl == NULL )
error = 1;
}