diff options
| author | dequis <dx@dxzone.com.ar> | 2015-02-22 19:04:08 -0300 |
|---|---|---|
| committer | dequis <dx@dxzone.com.ar> | 2015-02-22 19:44:40 -0300 |
| commit | 05816dd33396f92b7d9348a2acd18537ac18fa1e (patch) | |
| tree | 980ad6ad4c5efc040d19ec09ed1cecc0104b17eb /protocols/msn/ns.c | |
| parent | 91f06e5535d3711da06533495b197c1b8e545f82 (diff) | |
coverity: Fix some (harmless?) use-after-free with g_slist_remove()
These were passing a pointer to a variable right after it was g_free()'d
They are most likely harmless as g_slist_remove() probably just needs
the pointer location, but fixing it anyway.
Diffstat (limited to 'protocols/msn/ns.c')
| -rw-r--r-- | protocols/msn/ns.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/protocols/msn/ns.c b/protocols/msn/ns.c index f6c553a8..02abc52c 100644 --- a/protocols/msn/ns.c +++ b/protocols/msn/ns.c @@ -943,10 +943,9 @@ void msn_ns_oim_send_queue(struct im_connection *ic, GSList **msgq) while (*msgq != NULL) { struct msn_message *m = (*msgq)->data; + *msgq = g_slist_remove(*msgq, m); g_free(m->who); g_free(m->text); g_free(m); - - *msgq = g_slist_remove(*msgq, m); } } |