purple: Fix handling of empty, immediate roomlist results

Two issues here:

1. SIPE called in_progress(FALSE) immediately (which decreases refcount),
before purple_roomlist_get_list() could return (which would normally
increase refcount). The first refcount decrease steals it from the prpl,
and bad things happen.

Added an initialized flag to only do that decrease after it was
increased first. This is similar to how pidgin sets a 'dialog' attribute
after the purple_roomlist_get_list() call, and skips the unref if it's
not set.

2. The code assumed that NULL return value means room listing not
supported. That's not quite true, so now it checks in the prpl info to
see if roomlist_get_list is defined.

Also, made purple_roomlist_data more private.

1 files changed, 22 insertions, 4 deletions

diff --git a/protocols/purple/purple.c b/protocols/purple/purple.c
index 374b826b..6b043101 100644
--- a/protocols/purple/purple.c
+++ b/protocols/purple/purple.c
@@ -53,6 +53,13 @@ struct request_input_data {
 	guint id;
 };
 
+struct purple_roomlist_data {
+	GSList *chats;
+	gint topic;
+	gboolean initialized;
+};
+
+
 struct im_connection *purple_ic_by_pa(PurpleAccount *pa)
 {
 	GSList *i;
@@ -770,13 +777,21 @@ void purple_chat_list(struct im_connection *ic, const char *server)
 {
 	PurpleRoomlist *list;
 	struct purple_data *pd = ic->proto_data;
+	PurplePlugin *prpl = purple_plugins_find_with_id(pd->account->protocol_id);
+	PurplePluginProtocolInfo *pi = prpl->info->extra_info;
+
+	if (!pi || !pi->roomlist_get_list) {
+		imcb_log(ic, "Room listing unsupported by this purple plugin");
+		return;
+	}
 
 	list = purple_roomlist_get_list(pd->account->gc);
 
 	if (list) {
+		struct purple_roomlist_data *rld = list->ui_data;
+		rld->initialized = TRUE;
+
 		purple_roomlist_ref(list);
-	} else {
-		imcb_log(ic, "Room listing unsupported by this purple plugin");
 	}
 }
 
@@ -1381,7 +1396,7 @@ static void prplcb_roomlist_in_progress(PurpleRoomlist *list, gboolean in_progre
 	struct im_connection *ic;
 	struct purple_roomlist_data *rld = list->ui_data;
 
-	if (in_progress) {
+	if (in_progress || !rld) {
 		return;
 	}
 
@@ -1392,7 +1407,10 @@ static void prplcb_roomlist_in_progress(PurpleRoomlist *list, gboolean in_progre
 	rld->chats = NULL;
 
 	bee_chat_list_finish(ic);
-	purple_roomlist_unref(list);
+
+	if (rld->initialized) {
+		purple_roomlist_unref(list);
+	}
 }
 
 static void prplcb_roomlist_destroy(PurpleRoomlist *list)