aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTom Hukins <tom@eborcom.com>2019-04-09 14:50:04 +0100
committerTom Hukins <tom@eborcom.com>2019-04-09 14:50:04 +0100
commit889bc287bbfc8eddacae4c19f573b6ea18fbfbac (patch)
treeaae9393a56a0733c014bcc7f5ef34e28812ad8da
parent0d9f437e6455e6041cc067973efb47f0d88b4e47 (diff)
Avoid string eval
Instead, load the required module directly.
-rw-r--r--perllib/FixMyStreet/Roles/PhotoSet.pm5
1 files changed, 2 insertions, 3 deletions
diff --git a/perllib/FixMyStreet/Roles/PhotoSet.pm b/perllib/FixMyStreet/Roles/PhotoSet.pm
index 2a6863cff..4a40ef3f9 100644
--- a/perllib/FixMyStreet/Roles/PhotoSet.pm
+++ b/perllib/FixMyStreet/Roles/PhotoSet.pm
@@ -19,9 +19,8 @@ Return a PhotoSet object for all photos attached to this field
sub get_photoset {
my ($self) = @_;
- my $class = 'FixMyStreet::App::Model::PhotoSet';
- eval "use $class";
- return $class->new({
+ require FixMyStreet::App::Model::PhotoSet;
+ return FixMyStreet::App::Model::PhotoSet->new({
db_data => $self->photo,
object => $self,
});