diff options
| author | Struan Donald <struan@exo.org.uk> | 2012-04-24 16:53:51 +0100 |
|---|---|---|
| committer | Struan Donald <struan@exo.org.uk> | 2012-04-24 16:53:51 +0100 |
| commit | 21a21dcbba632a0dc854416fc1fbb3147cb63610 (patch) | |
| tree | 412f8422fb5e73f0ce42486584a1404e30828946 | |
| parent | 0579ab2e6d4cf0c6c6cc009df3c57f9f848e346e (diff) | |
add in first_name, last_name and email attribute[] params
| -rw-r--r-- | perllib/FixMyStreet/SendReport/Open311.pm | 1 | ||||
| -rw-r--r-- | perllib/Open311.pm | 1 | ||||
| -rw-r--r-- | t/open311.t | 4 |
3 files changed, 3 insertions, 3 deletions
diff --git a/perllib/FixMyStreet/SendReport/Open311.pm b/perllib/FixMyStreet/SendReport/Open311.pm index 804e876ee..5cde6faed 100644 --- a/perllib/FixMyStreet/SendReport/Open311.pm +++ b/perllib/FixMyStreet/SendReport/Open311.pm @@ -41,6 +41,7 @@ sub send { push @$extra, { name => 'public_anonymity_required', value => $row->anonymous ? 'TRUE' : 'FALSE' }; push @$extra, { name => 'email_alerts_requested', value => 'FALSE' }; # always false as can never request them push @$extra, { name => 'requested_datetime', value => $row->confirmed }; + push @$extra, { name => 'email', value => $row->user->email }; $row->extra( $extra ); } diff --git a/perllib/Open311.pm b/perllib/Open311.pm index 23208df1b..4440d386e 100644 --- a/perllib/Open311.pm +++ b/perllib/Open311.pm @@ -104,7 +104,6 @@ sub _populate_service_request_params { my $attr_name = $attr->{name}; if ( $attr_name eq 'first_name' || $attr_name eq 'last_name' ) { $params->{$attr_name} = $attr->{value} if $attr->{value}; - next; } $attr_name =~ s/fms_extra_//; my $name = sprintf( 'attribute[%s]', $attr_name ); diff --git a/t/open311.t b/t/open311.t index 83b81d8aa..77eefba0e 100644 --- a/t/open311.t +++ b/t/open311.t @@ -122,8 +122,8 @@ for my $test ( params => [ [ 'first_name', 'First', 'first name correct' ], [ 'last_name', 'Last', 'last name correct' ], - [ 'attribute[first_name]', undef, 'no first_name attribute param' ], - [ 'attribute[last_name]', undef, 'no last_name attribute param' ], + [ 'attribute[first_name]', 'First', 'first_name attribute param correct' ], + [ 'attribute[last_name]', 'Last', 'last_name attribute param correct' ], ], }, { |