aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatthew Somerville <matthew-github@dracos.co.uk>2018-07-03 12:33:19 +0100
committerMatthew Somerville <matthew-github@dracos.co.uk>2018-07-03 12:33:19 +0100
commit7d6d6fd9ae50eeb7b96743d59e8e8d7b36c5a21a (patch)
tree96f9a410b1af12f092a0bc57dd3b272366c2dd0b
parent419ed059989e7c0718de0dda436f1928200b6518 (diff)
Allow any user who sees private checkbox to use it
-rw-r--r--CHANGELOG.md1
-rw-r--r--perllib/FixMyStreet/App/Controller/Report.pm4
2 files changed, 3 insertions, 2 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 82cca72b5..6ca968d5c 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -19,6 +19,7 @@
- Defect type is recorded if category change made. #2172
- [UK] Store body ID on council/ward alerts. #2175
- Show all fixed issues when staff user uses map page filter #2176
+ - Allow any user who can see private checkbox to use it.
- Admin improvements:
- Mandatory defect type selection if defect raised.
- Send login email button on user edit page #2041
diff --git a/perllib/FixMyStreet/App/Controller/Report.pm b/perllib/FixMyStreet/App/Controller/Report.pm
index a1f357644..a4a726c51 100644
--- a/perllib/FixMyStreet/App/Controller/Report.pm
+++ b/perllib/FixMyStreet/App/Controller/Report.pm
@@ -357,8 +357,6 @@ sub inspect : Private {
my %update_params = ();
if ($permissions->{report_inspect}) {
- $problem->non_public($c->get_param('non_public') ? 1 : 0);
-
$problem->set_extra_metadata( traffic_information => $c->get_param('traffic_information') );
if ( my $info = $c->get_param('detailed_information') ) {
@@ -432,6 +430,8 @@ sub inspect : Private {
}
}
+ $problem->non_public($c->get_param('non_public') ? 1 : 0);
+
if ( !$c->forward( '/admin/report_edit_location', [ $problem ] ) ) {
# New lat/lon isn't valid, show an error
$valid = 0;