aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDave Arter <davea@mysociety.org>2019-11-01 10:56:01 +0000
committerDave Arter <davea@mysociety.org>2019-12-09 12:48:13 +0000
commite2cb1544c5711b06baaece34b99d297661128e92 (patch)
tree163dfd6f4bd1e2f00dc5c8b432fe9800efa07cf4
parent25a690e3a013db3143ce81a79f107b57dfb92ed9 (diff)
Break inspector extra details section into own template
-rw-r--r--templates/web/base/report/_inspect.html34
-rw-r--r--templates/web/base/report/inspect/_extra_details_field.html10
-rw-r--r--templates/web/base/report/inspect/extra_details.html23
3 files changed, 34 insertions, 33 deletions
diff --git a/templates/web/base/report/_inspect.html b/templates/web/base/report/_inspect.html
index ca1256bc8..771942b16 100644
--- a/templates/web/base/report/_inspect.html
+++ b/templates/web/base/report/_inspect.html
@@ -60,39 +60,7 @@
[% IF permissions.report_edit_priority OR permissions.report_inspect %]
<div class="inspect-section">
- <p>
- <label for="problem_priority">[% loc('Priority') %]</label>
- <select name="priority" id="problem_priority" class="form-control">
- <option value="" [% 'selected' UNLESS problem.response_priority_id OR has_default_priority %]>-</option>
- [% FOREACH priority IN problem.response_priorities %]
- <option value="[% priority.id %]" [% 'selected' IF ( problem.response_priority_id == priority.id ) OR priority.is_default %][% 'disabled' IF priority.deleted %]>[% priority.name | html %]</option>
- [% END %]
- </select>
- </p>
-
- [% IF permissions.report_inspect %]
- <p>
- <label for="traffic_information">[% loc('Traffic management required?') %]</label>
- [% traffic_info = problem.get_extra_metadata('traffic_information') %]
- <select id="traffic_information" name="traffic_information" class="form-control">
- <option value=""[% ' selected' IF NOT traffic_info %]>-</option>
- [% FOREACH option IN problem.traffic_management_options %]
- <option value='[% option %]'[% ' selected' IF traffic_info == option %]>[% option %]</option>
- [% END %]
- </select>
- </p>
- <p>
- <label for="detailed_information">[% loc('Extra details') %]</label>
- [% IF max_detailed_info_length %]
- <span id="detailed_information_length">
- [% tprintf(loc('%d characters maximum'), max_detailed_info_length) %]
- </span>
- [% END %]
- <textarea rows="2" name="detailed_information" id="detailed_information" class="form-control"
- [% IF max_detailed_info_length %]data-max-length="[% max_detailed_info_length %]"[% END %]>[% problem.get_extra_metadata('detailed_information') | html %]</textarea>
- </p>
- [% END %]
-
+ [% INCLUDE 'report/inspect/extra_details.html' %]
</div>
[% END %]
diff --git a/templates/web/base/report/inspect/_extra_details_field.html b/templates/web/base/report/inspect/_extra_details_field.html
new file mode 100644
index 000000000..6a0dfaeec
--- /dev/null
+++ b/templates/web/base/report/inspect/_extra_details_field.html
@@ -0,0 +1,10 @@
+<p>
+ <label for="detailed_information">[% loc('Extra details') %]</label>
+ [% IF max_detailed_info_length %]
+ <span id="detailed_information_length">
+ [% tprintf(loc('%d characters maximum'), max_detailed_info_length) %]
+ </span>
+ [% END %]
+ <textarea rows="2" name="detailed_information" id="detailed_information" class="form-control"
+ [% IF max_detailed_info_length %]data-max-length="[% max_detailed_info_length %]"[% END %]>[% problem.get_extra_metadata('detailed_information') | html %]</textarea>
+</p>
diff --git a/templates/web/base/report/inspect/extra_details.html b/templates/web/base/report/inspect/extra_details.html
new file mode 100644
index 000000000..7777e9a78
--- /dev/null
+++ b/templates/web/base/report/inspect/extra_details.html
@@ -0,0 +1,23 @@
+<p>
+ <label for="problem_priority">[% loc('Priority') %]</label>
+ <select name="priority" id="problem_priority" class="form-control">
+ <option value="" [% 'selected' UNLESS problem.response_priority_id OR has_default_priority %]>-</option>
+ [% FOREACH priority IN problem.response_priorities %]
+ <option value="[% priority.id %]" [% 'selected' IF ( problem.response_priority_id == priority.id ) OR priority.is_default %][% 'disabled' IF priority.deleted %]>[% priority.name | html %]</option>
+ [% END %]
+ </select>
+</p>
+
+[% IF permissions.report_inspect %]
+ <p>
+ <label for="traffic_information">[% loc('Traffic management required?') %]</label>
+ [% traffic_info = problem.get_extra_metadata('traffic_information') %]
+ <select id="traffic_information" name="traffic_information" class="form-control">
+ <option value=""[% ' selected' IF NOT traffic_info %]>-</option>
+ [% FOREACH option IN problem.traffic_management_options %]
+ <option value='[% option %]'[% ' selected' IF traffic_info == option %]>[% option %]</option>
+ [% END %]
+ </select>
+ </p>
+ [% INCLUDE 'report/inspect/_extra_details_field.html' %]
+[% END %]