diff options
author | Matthew Somerville <matthew-github@dracos.co.uk> | 2016-09-22 19:24:10 +0100 |
---|---|---|
committer | Matthew Somerville <matthew-github@dracos.co.uk> | 2017-03-09 16:58:20 +0000 |
commit | 8b43050c549bc3bb233bab2b7bd5652dfbb39a12 (patch) | |
tree | 4609e33de0a3de95e88e831d83dae2dcbb763c07 /perllib/FixMyStreet/Cobrand/Greenwich.pm | |
parent | 491eb26e463c5976a159060782c0217cf450d4fc (diff) |
Refactor SendReport::Open311 to use cobrand hooks.
Avoid doing cobrand-specific logic within SendReport::Open311.
The hooks defined are:
open311_config: set extra fields
open311_pre_send: set endpoints and munge data
These are tested in the new t/app/sendreport/open311.t, which does
not send any actual reports, but just checks that all the data is
munged into the expected format. (tests under t/open311* should
already test the actual sending)
Remove unused Open311 special cases.
Diffstat (limited to 'perllib/FixMyStreet/Cobrand/Greenwich.pm')
-rw-r--r-- | perllib/FixMyStreet/Cobrand/Greenwich.pm | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/perllib/FixMyStreet/Cobrand/Greenwich.pm b/perllib/FixMyStreet/Cobrand/Greenwich.pm index 7d6058145..700a12782 100644 --- a/perllib/FixMyStreet/Cobrand/Greenwich.pm +++ b/perllib/FixMyStreet/Cobrand/Greenwich.pm @@ -61,4 +61,13 @@ sub on_map_default_max_pin_age { return '21 days'; } +sub open311_config { + my ($self, $row, $h, $params) = @_; + + my $extra = $row->get_extra_fields; + # Greenwich doesn't have category metadata to fill this + push @$extra, { name => 'external_id', value => $row->id }; + $row->set_extra_fields( @$extra ); +} + 1; |