diff options
| author | Matthew Somerville <matthew@mysociety.org> | 2013-05-02 18:48:39 +0100 |
|---|---|---|
| committer | Matthew Somerville <matthew@mysociety.org> | 2013-05-02 20:48:05 +0100 |
| commit | 9b6a6fd63daacf67cddb4f5ab7bbcd0375082696 (patch) | |
| tree | 2f832a82aac5ce6050090a3d250b7bec93274902 /perllib/FixMyStreet/DB/ResultSet/Problem.pm | |
| parent | c4b3f85594e91c772011dffef2da2498ee5c8a5e (diff) | |
Consolidate sending backoff for different types of sender.
Diffstat (limited to 'perllib/FixMyStreet/DB/ResultSet/Problem.pm')
| -rw-r--r-- | perllib/FixMyStreet/DB/ResultSet/Problem.pm | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/perllib/FixMyStreet/DB/ResultSet/Problem.pm b/perllib/FixMyStreet/DB/ResultSet/Problem.pm index dc1c5c248..07848d782 100644 --- a/perllib/FixMyStreet/DB/ResultSet/Problem.pm +++ b/perllib/FixMyStreet/DB/ResultSet/Problem.pm @@ -236,7 +236,6 @@ sub send_reports { my $send_report = FixMyStreet::SendReport->new(); my $senders = $send_report->get_senders; - my %sending_skipped_by_method; my $debug_unsent_count = 0; debug_print("starting to loop through unsent problem reports...") if $debug_mode; @@ -348,8 +347,6 @@ sub send_reports { if ( $reporters{ $sender }->should_skip( $row ) ) { debug_print("skipped by sender " . $sender_info->{method} . " (might be due to previous failed attempts?)", $row->id) if $debug_mode; - $sending_skipped_by_method{ $sender }++ if - $reporters{ $sender }->skipped; } else { debug_print("OK, adding recipient body " . $body->id . ":" . $body->name . ", " . $body->send_method, $row->id) if $debug_mode; push @dear, $body->name; @@ -459,15 +456,6 @@ sub send_reports { print " " . $notgot{$e}{$c} . " problem, to $e category $c (" . $note{$e}{$c}. ")\n"; } } - if (keys %sending_skipped_by_method) { - my $c = 0; - print "\nProblem reports that send-reports did not attempt to send the following:\n"; - foreach my $send_method (sort keys %sending_skipped_by_method) { - printf " %-24s %4d\n", "$send_method:", $sending_skipped_by_method{$send_method}; - $c+=$sending_skipped_by_method{$send_method}; - } - printf " %-24s %4d\n", "Total:", $c; - } my $sending_errors = ''; my $unsent = FixMyStreet::App->model("DB::Problem")->search( { state => [ 'confirmed', 'fixed' ], |