Use same handling for cron and non-cron email.

This means that e.g. SMTP authentication is used when set up by all
emails, not just non-cron ones. Fixes #988.

1 files changed, 1 insertions, 3 deletions

diff --git a/perllib/FixMyStreet/DB/ResultSet/Questionnaire.pm b/perllib/FixMyStreet/DB/ResultSet/Questionnaire.pm
index b7af9e60e..646967bfc 100644
--- a/perllib/FixMyStreet/DB/ResultSet/Questionnaire.pm
+++ b/perllib/FixMyStreet/DB/ResultSet/Questionnaire.pm
@@ -5,7 +5,6 @@ use strict;
 use warnings;
 use Encode;
 use Utils;
-use mySociety::EmailUtil;
 
 sub send_questionnaires {
     my ( $rs, $params ) = @_;
@@ -103,11 +102,10 @@ sub send_questionnaires_period {
                 From => [ $sender, $sender_name ],
             },
             $sender,
-            [ $row->user->email ],
             $params->{nomail},
             $cobrand
         );
-        if ($result == mySociety::EmailUtil::EMAIL_SUCCESS) {
+        unless ($result) {
             print "  ...success\n" if $params->{verbose};
             $row->update();
             $token->insert();