Remove any use of `my $x if $foo`.

As perlsyn says, "NOTE: The behaviour of a `my`, `state`, or `our`
modified with a statement modifier conditional or loop construct (for
example, `my $x if ...`) is undefined. The value of the `my` variable
may be `undef`, any previously assigned value, or possibly anything
else."

1 files changed, 3 insertions, 1 deletions

diff --git a/perllib/FixMyStreet/Script/Reports.pm b/perllib/FixMyStreet/Script/Reports.pm
index 5cadd4fa2..c1c4ab3f1 100644
--- a/perllib/FixMyStreet/Script/Reports.pm
+++ b/perllib/FixMyStreet/Script/Reports.pm
@@ -140,7 +140,9 @@ sub send(;$) {
             }
             $reporters{ $sender } ||= $sender->new();
 
-            my $inspection_required = $sender_info->{contact}->get_extra_metadata('inspection_required') if $sender_info->{contact};
+            my $inspection_required = $sender_info->{contact}
+                ? $sender_info->{contact}->get_extra_metadata('inspection_required')
+                : undef;
             if ( $inspection_required ) {
                 my $reputation_threshold = $sender_info->{contact}->get_extra_metadata('reputation_threshold') || 0;
                 my $reputation_threshold_met = 0;