indicate problem has been closed in alert

1 files changed, 8 insertions, 5 deletions

diff --git a/perllib/FixMyStreet/DB/ResultSet/AlertType.pm b/perllib/FixMyStreet/DB/ResultSet/AlertType.pm
index d5b2f5535..a7e6d9736 100644
--- a/perllib/FixMyStreet/DB/ResultSet/AlertType.pm
+++ b/perllib/FixMyStreet/DB/ResultSet/AlertType.pm
@@ -49,6 +49,7 @@ sub email_alerts ($) {
         # XXX Ugh - needs work
         $query =~ s/\?/alert.parameter/ if ($query =~ /\?/);
         $query =~ s/\?/alert.parameter2/ if ($query =~ /\?/);
+
         $query = dbh()->prepare($query);
         $query->execute();
         my $last_alert_id;
@@ -73,11 +74,13 @@ sub email_alerts ($) {
             }
 
             # create problem status message for the templates
-            $data{state_message} =
-              # XXXXXX test this
-              FixMyStreet::DB::Result::Problem::fixed_states()->{$row->{state}}
-              ? _("This report is currently marked as fixed.")
-              : _("This report is currently marked as open.");
+            if ( FixMyStreet::DB::Result::Problem::fixed_states()->{$row->{state}} ) {
+                $data{state_message} = _("This report is currently marked as fixed.");
+            } elsif ( FixMyStreet::DB::Result::Problem::closed_states()->{$row->{state}} ) {
+                $data{state_message} = _("This report is currently marked as closed.")
+            } else {
+                $data{state_message} = _("This report is currently marked as open.");
+            }
 
             my $url = $cobrand->base_url_for_emails( $row->{alert_cobrand_data} );
             if ($row->{item_text}) {