aboutsummaryrefslogtreecommitdiffstats
path: root/perllib/Open311/GetServiceRequestUpdates.pm
diff options
context:
space:
mode:
authorMatthew Somerville <matthew-github@dracos.co.uk>2018-08-06 17:05:52 +0100
committerMatthew Somerville <matthew-github@dracos.co.uk>2018-08-06 17:05:52 +0100
commit4223fc78261aad3f16b8ed8000a6bef77f41f708 (patch)
treed2b70a12cd1737cae5fc158735fc6c3ecd5d02d8 /perllib/Open311/GetServiceRequestUpdates.pm
parente46125e56cb922ebe8bbae527a53d06b28c173cc (diff)
parenta292b3a8bcca53f870a46d6868d288e22a595c58 (diff)
Merge branch 'issues/commercial/1123-fixed-state-thing'
Diffstat (limited to 'perllib/Open311/GetServiceRequestUpdates.pm')
-rw-r--r--perllib/Open311/GetServiceRequestUpdates.pm6
1 files changed, 4 insertions, 2 deletions
diff --git a/perllib/Open311/GetServiceRequestUpdates.pm b/perllib/Open311/GetServiceRequestUpdates.pm
index 4b1642506..480a78cf1 100644
--- a/perllib/Open311/GetServiceRequestUpdates.pm
+++ b/perllib/Open311/GetServiceRequestUpdates.pm
@@ -201,8 +201,10 @@ sub comment_text_for_request {
return $request->{description} if $request->{description};
- # Response templates are only triggered if the state/external status has changed
- my $state_changed = $state ne $old_state;
+ # Response templates are only triggered if the state/external status has changed.
+ # And treat any fixed state as fixed.
+ my $state_changed = $state ne $old_state
+ && !( $problem->is_fixed && FixMyStreet::DB::Result::Problem->fixed_states()->{$state} );
my $ext_code_changed = $ext_code ne $old_ext_code;
if ($state_changed || $ext_code_changed) {
my $state_params = {