diff options
| author | Matthew Somerville <matthew-github@dracos.co.uk> | 2019-04-25 17:09:31 +0100 |
|---|---|---|
| committer | Matthew Somerville <matthew-github@dracos.co.uk> | 2019-05-02 22:07:26 +0100 |
| commit | 54cad1e4d2474fba55485731ca9e2fd1779c524a (patch) | |
| tree | 0b1e765b8bac8b50953038cf6ae25b1aa312e0d1 /perllib/Open311/GetServiceRequests.pm | |
| parent | 4b4da81ffec527df9741c960d79294b48bb4dcaa (diff) | |
Fix some incorrect timezone code.
Times in the database should be stored in the application server's local
timezone, by e.g. using `current_timestamp`, or by setting that timezone
explicitly before storage (the database columns are all without timezone
so any timezone info is silently ignored). Reports & updates fetched via
Open311 and offline updates were being put into the TIME_ZONE setting if
present, meaning they were stored incorrectly for future usage.
Diffstat (limited to 'perllib/Open311/GetServiceRequests.pm')
| -rw-r--r-- | perllib/Open311/GetServiceRequests.pm | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/perllib/Open311/GetServiceRequests.pm b/perllib/Open311/GetServiceRequests.pm index 215361a10..194d8d296 100644 --- a/perllib/Open311/GetServiceRequests.pm +++ b/perllib/Open311/GetServiceRequests.pm @@ -109,9 +109,7 @@ sub create_problems { my $updated_time = eval { DateTime::Format::W3CDTF->parse_datetime( $request->{updated_datetime} || "" - )->set_time_zone( - FixMyStreet->time_zone || FixMyStreet->local_time_zone - ); + )->set_time_zone(FixMyStreet->local_time_zone); }; if ($@) { warn "Not creating problem $request_id for @{[$body->name]}, bad update time" @@ -125,9 +123,7 @@ sub create_problems { my $created_time = eval { DateTime::Format::W3CDTF->parse_datetime( $request->{requested_datetime} || "" - )->set_time_zone( - FixMyStreet->time_zone || FixMyStreet->local_time_zone - ); + )->set_time_zone(FixMyStreet->local_time_zone); }; $created_time = $updated_time if $@; |