More tests (and fixes to issues thrown up)

1 files changed, 215 insertions, 3 deletions

diff --git a/t/app/controller/reports_new.t b/t/app/controller/reports_new.t
index 506678459..dd353a903 100644
--- a/t/app/controller/reports_new.t
+++ b/t/app/controller/reports_new.t
@@ -36,9 +36,9 @@ foreach my $test (
         pc_alternatives => [],
     },
     {
-        pc              => 'glenthorpe',
-        errors          => [],
-        pc_alternatives => [
+        pc     => 'glenthorpe',
+        errors => [],
+        pc_alternatives => [   # TODO - should filter out these non-UK addresses
             'Glenthorpe Crescent, Leeds LS9 7, UK',
             'Glenthorpe Rd, Merton, Greater London SM4 4, UK',
             'Glenthorpe Ln, Katy, TX 77494, USA',
@@ -89,6 +89,218 @@ foreach my $test (
     is_deeply $mech->form_errors, [], "no errors for pc '$test->{pc}'";
     is_deeply $mech->extract_location, $test,
       "got expected location for pc '$test->{pc}'";
+}
+
+# test that the various bit of form get filled in and errors correctly
+# generated.
+foreach my $test (
+    {
+        msg    => 'all fields empty',
+        pc     => 'SW1A 1AA',
+        fields => {
+            title         => '',
+            detail        => '',
+            photo         => '',
+            name          => '',
+            may_show_name => '1',
+            email         => '',
+            phone         => '',
+        },
+        changes => {},
+        errors  => [
+            'Please enter a subject',
+            'Please enter some details',
+            'Please enter your name',
+            'Please enter your email',
+        ],
+    },
+    {
+        msg    => 'may_show_name defaults to true',
+        pc     => 'SW1A 1AA',
+        fields => {
+            title         => '',
+            detail        => '',
+            photo         => '',
+            name          => '',
+            may_show_name => undef,
+            email         => '',
+            phone         => '',
+        },
+        changes => { may_show_name => '1' },
+        errors  => [
+            'Please enter a subject',
+            'Please enter some details',
+            'Please enter your name',
+            'Please enter your email',
+        ],
+    },
+    {
+        msg    => 'may_show_name unchanged if name is present (stays false)',
+        pc     => 'SW1A 1AA',
+        fields => {
+            title         => '',
+            detail        => '',
+            photo         => '',
+            name          => 'Bob Jones',
+            may_show_name => undef,
+            email         => '',
+            phone         => '',
+        },
+        changes => {},
+        errors  => [
+            'Please enter a subject',
+            'Please enter some details',
+            'Please enter your email',
+        ],
+    },
+    {
+        msg    => 'may_show_name unchanged if name is present (stays true)',
+        pc     => 'SW1A 1AA',
+        fields => {
+            title         => '',
+            detail        => '',
+            photo         => '',
+            name          => 'Bob Jones',
+            may_show_name => '1',
+            email         => '',
+            phone         => '',
+        },
+        changes => {},
+        errors  => [
+            'Please enter a subject',
+            'Please enter some details',
+            'Please enter your email',
+        ],
+    },
+    {
+        msg    => 'title and details tidied up',
+        pc     => 'SW1A 1AA',
+        fields => {
+            title         => 'DOG SHIT ON WALLS',
+            detail        => 'on this portakabin - more of a portaloo HEH!!',
+            photo         => '',
+            name          => 'Bob Jones',
+            may_show_name => '1',
+            email         => '',
+            phone         => '',
+        },
+        changes => {
+            title => 'Dog poo on walls',
+            detail =>
+              'On this [portable cabin] - more of a [portable loo] HEH!!',
+        },
+        errors => [ 'Please enter your email', ],
+    },
+    {
+        msg    => 'name too short',
+        pc     => 'SW1A 1AA',
+        fields => {
+            title         => 'Test title',
+            detail        => 'Test detail',
+            photo         => '',
+            name          => 'DUDE',
+            may_show_name => '1',
+            email         => '',
+            phone         => '',
+        },
+        changes => {},
+        errors  => [
+'Please enter your full name, councils need this information - if you do not wish your name to be shown on the site, untick the box',
+            'Please enter your email',
+        ],
+    },
+    {
+        msg    => 'name is anonymous',
+        pc     => 'SW1A 1AA',
+        fields => {
+            title         => 'Test title',
+            detail        => 'Test detail',
+            photo         => '',
+            name          => 'anonymous',
+            may_show_name => '1',
+            email         => '',
+            phone         => '',
+        },
+        changes => {},
+        errors  => [
+'Please enter your full name, councils need this information - if you do not wish your name to be shown on the site, untick the box',
+            'Please enter your email',
+        ],
+    },
+    {
+        msg    => 'email invalid',
+        pc     => 'SW1A 1AA',
+        fields => {
+            title         => 'Test title',
+            detail        => 'Test detail',
+            photo         => '',
+            name          => 'Joe Smith',
+            may_show_name => '1',
+            email         => 'not an email',
+            phone         => '',
+        },
+        changes => { email => 'notanemail', },
+        errors  => [ 'Please enter a valid email', ],
+    },
+    {
+        msg    => 'cleanup title and detail',
+        pc     => 'SW1A 1AA',
+        fields => {
+            title         => "   Test   title   ",
+            detail        => "   first line   \n\n second\nline\n\n   ",
+            photo         => '',
+            name          => '',
+            may_show_name => '1',
+            email         => '',
+            phone         => '',
+        },
+        changes => {
+            title  => 'Test title',
+            detail => "First line\n\nSecond line",
+        },
+        errors => [ 'Please enter your name', 'Please enter your email', ],
+    },
+    {
+        msg    => 'clean up name and email',
+        pc     => 'SW1A 1AA',
+        fields => {
+            title         => '',
+            detail        => '',
+            photo         => '',
+            name          => '  Bob    Jones   ',
+            may_show_name => '1',
+            email         => '   BOB @ExAmplE.COM   ',
+            phone         => '',
+        },
+        changes => {
+            name  => 'Bob Jones',
+            email => 'bob@example.com',
+        },
+        errors => [ 'Please enter a subject', 'Please enter some details', ],
+    },
+  )
+{
+    pass "--- $test->{msg} ---";
+    $mech->get_ok('/reports/new');
+
+    # submit initial pc form
+    $mech->submit_form_ok( { with_fields => { pc => $test->{pc} } },
+        "submit location" );
+    is_deeply $mech->form_errors, [], "no errors for pc '$test->{pc}'";
+
+    # submit the main form
+    $mech->submit_form_ok( { with_fields => $test->{fields} }, "submit form" );
+
+    # check that we got the errors expected
+    is_deeply $mech->form_errors, $test->{errors}, "check errors";
+
+    # check that fields have changed as expected
+    my $new_values = {
+        %{ $test->{fields} },     # values added to form
+        %{ $test->{changes} },    # changes we expect
+    };
+    is_deeply $mech->visible_form_values, $new_values,
+      "values correctly changed";
 
 }