diff options
| author | M Somerville <matthew-github@dracos.co.uk> | 2020-09-18 20:11:31 +0100 |
|---|---|---|
| committer | M Somerville <matthew-github@dracos.co.uk> | 2020-09-25 11:59:52 +0100 |
| commit | ba1179d0378a35809f4eb2df0ceb3e189c4bd1bc (patch) | |
| tree | 24d868cbd7ef96c8e13a57bec2ee362090cf5583 /t/app/controller | |
| parent | 49a2bf517a60d71b251bdf7e23e5717c792f527d (diff) | |
Show username error in correct place only.
Diffstat (limited to 't/app/controller')
| -rw-r--r-- | t/app/controller/report_new_errors.t | 20 | ||||
| -rw-r--r-- | t/app/controller/report_new_open311.t | 4 | ||||
| -rw-r--r-- | t/app/controller/report_updates.t | 19 |
3 files changed, 39 insertions, 4 deletions
diff --git a/t/app/controller/report_new_errors.t b/t/app/controller/report_new_errors.t index f45f13c1e..c82a5fa13 100644 --- a/t/app/controller/report_new_errors.t +++ b/t/app/controller/report_new_errors.t @@ -702,6 +702,26 @@ subtest "test password errors for a user who is signing in as they report" => su title => 'Test Report', detail => 'Test report details.', photo1 => '', + username => 'test-2', + password_sign_in => 'secret1', + category => 'Street lighting', + } + }, + "submit with wrong password" + ); + + is_deeply $mech->page_errors, [ + "Please enter a valid email", + "There was a problem with your login information. If you cannot remember your password, or do not have one, please fill in the \x{2018}No\x{2019} section of the form.", + ], "check there were errors"; + + $mech->submit_form_ok( + { + button => 'submit_sign_in', + with_fields => { + title => 'Test Report', + detail => 'Test report details.', + photo1 => '', username => 'test-2@example.com', password_sign_in => 'secret1', category => 'Street lighting', diff --git a/t/app/controller/report_new_open311.t b/t/app/controller/report_new_open311.t index 7cd6dca09..9a8063a84 100644 --- a/t/app/controller/report_new_open311.t +++ b/t/app/controller/report_new_open311.t @@ -130,8 +130,8 @@ foreach my $test ( 'This information is required', 'Please enter a subject', 'Please enter some details', - 'Please enter your email', 'Please enter your name', + 'Please enter your email', ], submit_with => { title => 'test', @@ -170,8 +170,8 @@ foreach my $test ( 'This information is required', 'Please enter a subject', 'Please enter some details', - 'Please enter your email', 'Please enter your name', + 'Please enter your email', ], submit_with => { title => 'test', diff --git a/t/app/controller/report_updates.t b/t/app/controller/report_updates.t index 92cbed861..7ae5ed7b2 100644 --- a/t/app/controller/report_updates.t +++ b/t/app/controller/report_updates.t @@ -285,7 +285,7 @@ for my $test ( password_sign_in => '', }, changes => {}, - field_errors => [ 'Please enter a message', 'Please enter your email', 'Please enter your name' ] + field_errors => [ 'Please enter a message', 'Please enter your name', 'Please enter your email' ] }, { desc => 'Invalid email, no message', @@ -303,7 +303,7 @@ for my $test ( password_register => '', }, changes => {}, - field_errors => [ 'Please enter a message', 'Please enter a valid email', 'Please enter your name' ] + field_errors => [ 'Please enter a message', 'Please enter your name', 'Please enter a valid email' ] }, { desc => 'email with spaces, no message', @@ -1223,6 +1223,21 @@ $report->comments->delete; for my $test ( { + desc => 'submit an update with bad email and password', + form_values => { + submit_update => 1, + username => 'registered@', + update => 'Update from a user', + add_alert => undef, + password_sign_in => 'secret', + }, + field_errors => [ + 'Please enter a valid email', + "There was a problem with your login information. If you cannot remember your password, or do not have one, please fill in the \x{2018}No\x{2019} section of the form.", + 'Please enter your name', # FIXME Not really necessary error + ], + }, + { desc => 'submit an update for a registered user, signing in with wrong password', form_values => { submit_update => 1, |