Add Extra role to ease use of {extra} field.

Historically, the extra field has been used in two different ways by
different cobrands, both as a list (e.g. Open311 category fields) and a
hash (e.g. the Zurich cobrand).

This commit consolidates usage, adding an API to make use of the field
easier and always returning a hash for the code to use. Fixes #1018.

1 files changed, 20 insertions, 0 deletions

diff --git a/t/cobrand/bromley.t b/t/cobrand/bromley.t
index 6437ba3bd..fdded5606 100644
--- a/t/cobrand/bromley.t
+++ b/t/cobrand/bromley.t
@@ -8,6 +8,11 @@ my $mech = FixMyStreet::TestMech->new;
 # Create test data
 my $user = $mech->create_user_ok( 'bromley@example.com' );
 my $body = $mech->create_body_ok( 2482, 'Bromley', id => 2482 );
+$mech->create_contact_ok(
+    body_id => $body->id,
+    category => 'Other',
+    email => 'LIGHT',
+);
 
 my @reports = $mech->create_problems_for_body( 1, $body->id, 'Test', {
     cobrand => 'bromley',
@@ -36,6 +41,21 @@ $mech->content_contains( 'marked as in progress' );
 $mech->content_contains( 'marks it as unable to fix' );
 $mech->content_contains( 'marked as no further action' );
 
+subtest 'testing special Open311 behaviour', sub {
+    $report->set_extra_fields();
+    $report->update;
+    $body->update( { send_method => 'Open311', endpoint => 'http://bromley.endpoint.example.com', jurisdiction => 'FMS', api_key => 'test' } );
+    FixMyStreet::override_config {
+        SEND_REPORTS_ON_STAGING => 1,
+    }, sub {
+        FixMyStreet::App->model('DB::Problem')->send_reports();
+    };
+    $report->discard_changes;
+    ok $report->whensent, 'Report marked as sent';
+    is $report->send_method_used, 'Open311', 'Report sent via Open311';
+    is $report->external_id, 248, 'Report has right external ID';
+};
+
 # Clean up
 $mech->delete_user($user);
 $mech->delete_problems_for_body( $body->id );