diff options
| -rw-r--r-- | perllib/Open311/GetServiceRequestUpdates.pm | 6 | ||||
| -rw-r--r-- | t/open311/getservicerequestupdates.t | 6 |
2 files changed, 1 insertions, 11 deletions
diff --git a/perllib/Open311/GetServiceRequestUpdates.pm b/perllib/Open311/GetServiceRequestUpdates.pm index c0da7793f..3d593a4eb 100644 --- a/perllib/Open311/GetServiceRequestUpdates.pm +++ b/perllib/Open311/GetServiceRequestUpdates.pm @@ -104,7 +104,6 @@ sub update_comments { next if @args && ($updated lt $args[0] || $updated gt $args[1]); my $problem; - my $match_field = 'external_id'; my $criteria = { external_id => $request_id, }; @@ -119,7 +118,6 @@ sub update_comments { $criteria = { id => $request->{fixmystreet_id}, }; - $match_field = 'fixmystreet id'; } $problem = $self->schema->resultset('Problem')->to_body($body)->search( $criteria ); @@ -221,10 +219,6 @@ sub update_comments { } } } - # we get lots of comments that are not related to FMS issues from Lewisham so ignore those otherwise - # way too many warnings. - } elsif (FixMyStreet->config('STAGING_SITE') and $body->name !~ /Lewisham/) { - warn "Failed to match comment to problem with $match_field $request_id for " . $body->name . "\n"; } } diff --git a/t/open311/getservicerequestupdates.t b/t/open311/getservicerequestupdates.t index 3cb2fda69..32f1ec2ee 100644 --- a/t/open311/getservicerequestupdates.t +++ b/t/open311/getservicerequestupdates.t @@ -1108,11 +1108,7 @@ subtest 'check matching on fixmystreet_id overrides service_request_id' => sub { system_user => $user, ); - warning_like { - $update->update_comments( $o, $bodies{2482} ) - } - qr/Failed to match comment to problem with fixmystreet id @{[$problem->external_id]} for Bromley/, - "warning emitted for bad fixmystreet id"; + $update->update_comments( $o, $bodies{2482} ); $problem->discard_changes; is $problem->comments->count, 2, 'two comments after fetching updates'; |