| Commit message (Collapse) | Author | Age | Lines |
|---|
| ... | |
| | |\ |
|
| | | |
| | |
| | |
| | |
| | | |
The test has to now create a new comment object each time as
`get_cobrand_logged` is cached on the object.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If an update has a fixmystreet_id field then use the contents of that in
preference to the external_id field to match an update to a problem.
This handles the case where a report in a third party system passes
through different types (eg inspection and defect), resulting in the
external id changing. In this case it is sometimes possible to include
the fixmystreet id in each type and hence use that to match things up at
the fixmystreet side.
|
| | | |
| | |
| | |
| | |
| | | |
Remove the config that stopped us sending easting/northing if the user
had not clicked the map.
|
| | | |
| | |
| | |
| | |
| | | |
If an Open311 server returned an empty set of values, it was possible
for this template to then display a set of empty dropdown options.
|
| | | |
| | |
| | |
| | |
| | | |
Otherwise running on a site where one body ID is a substring
of another, comments can get processed for the wrong body.
|
| | | | |
|
| | |/
| |
| |
| |
| | |
After the change in 1cff2a0e, we need to make sure this is set
so that the relevant fields are not shown in the front end.
|
| | | |
|
| | |
| |
| |
| | |
Otherwise any such fields are lost upon a manual edit.
|
| | |\ |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Without doing this, a call to e.g. $contact->set_extra_fields(@meta)
in PopulateServiceList.pm, with an unchanged meta that contains some
Unicode values, can write to the database (and cause an unneeded row
in the history table), because the column from the database is UTF-8
decoded, whilst the new text is UTF-8 encoded.
It looks like an attempt was made in filter_from_storage to fix this
issue, but the column comparison for marking a column as dirty takes
place without this being called.
|
| | | |
| | |
| | |
| | |
| | |
| | | |
The form may be brought in via JS, so we have to add an event to
something that will always be there (or alternatively set up when
pulled in, which was the old pre-duplicates.js behaviour).
|
| | | | |
|
| | |/ |
|
| | |\ |
|
| | | |
| | |
| | |
| | |
| | |
| | | |
Rather than compile it all into on big string for output, write the
output as we go. Also output headers to encourage intermediaries to
stream as well.
|
| | |\ \ |
|
| | | | | |
|
| | | |/
| | |
| | |
| | |
| | | |
If the pin is dragged, then category changed,
the pin will not be in the centre of the map.
|
| | |\ \ |
|
| | | |/
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Reduce the space between checkbox and label, so the text isn't lost if
the page is zoomed in. Fixes #2411.
Replace the creator_fixed question with segmented control to match the
full questionnaire, and the admin verified checkboxes with inline-text
as they need no padding. Having done that, all uses of .inline are now
on their own lines, so no post-padding is needed any longer, but we’ll
leave some in case of future use.
|
| | |\ \ |
|
| | | |/
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
On some UK council cobrands, some reports listed might not have been sent
to that council, so links to those must go to the national site. However,
using absolute URLs for all these reports means that sometimes you change
domain when you don't need to (eg. if you’re on osm.fixmystreet.com or an
aliased version of the site), which can cause confusion. State when we’re
happy to use a relative link (ie. web-facing report links, not emails, or
share links) and do that when we can.
|
| | |\ \ |
|
| | | | | |
|
| | | |/
| |/|
| | |
| | |
| | | |
This simplifies the places where a date range is used;
it also makes Dashboard date parsing more flexible.
|
| | |/ |
|
| | |
| |
| |
| | |
IE11 does not support input type=date, so we will get whatever they write.
|
| | |\ |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | |/ |
|
| | |\ |
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The previously staff-only fixmystreet.set_up.manage_duplicates() has
been promoted from staff.js to its own file so that we can use it to
display the duplicate suggestions on the `/report/new` form.
render_duplicate_list (the old refresh_duplicate_list) no longer filters
or slices the reports_list returned by the ajax call, since it turns out
the server handles all of that (`sub _nearby_json` in `Report.pm` and
`sub nearby` in `Nearby.pm`).
Since the expandable list items include the "fancybox" image previews,
the fancybox CSS now has to be included in the `/report/new` page head,
hence the addition of "photo-js.html" in `fill_in_details.html`.
The “Get updates” flow reuses the same JavaScript that handles the
submission of the "Get updates" drawer at the bottom of around pages.
|
| | | |
| | |
| | |
| | | |
Unused right now, but will be soon, for the duplicate suggestion UI.
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | | |
There’s no need for this `--reports` to be there, so let’s start phasing
it out.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
`_item_expandable.html` is an alternative to regular list items, where
you can display extra information on the first click on the item, and
then also, optionally, offer a further action, as a separate button.
Right now the expandable list items aren’t used anywhere, but we’ll
soon be using them in the duplicate report suggestion UI for council
staff and the public.
|
| | | |
| | |
| | |
| | |
| | | |
Moving the 4em padding from _layout.scss to _base.scss helps separate
the content on /report/<id> and /report/new pages from the nav below.
|
| | | | |
|
| | | | |
|
| | |/ |
|
| | |\ |
|
| | | | |
|
| | | |
| | |
| | |
| | | |
Fixes #1957
|
