| Commit message (Collapse) | Author | Age | Lines |
|
|
|
|
|
|
|
|
| |
Update the reports with a bounding box, similar to on around pages.
This is made slightly trickier because we don't want to do anything
on page load (we already have the pins), we need to reload when the
zoom changes, and we don't want the strategy to get confused by its
first redraw, e.g. on pin hover, We also need to turn off the zoom-
to-bounds if we've got a bounding box in the URL.
|
|
|
|
|
|
| |
As the templates were using `grep`, they failed to match on a category
such as "Footpaths (right of way)". Changing the stash variables to be
hashes instead of lists makes checking for a key simpler. Fixes #1688.
|
|
|
|
|
|
|
| |
The report-sending code has allowed multiple emails for a long time, but the
admin wouldn't allow you to enter multiple emails for each contact.
Fixes mysociety/FixMyStreet-Commercial#835
|
| |
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Email::Send is long deprecated and uses submodules that no longer work
correctly (e.g. Net::SMTP::TLS breaks with recent IO::Socket::SSL). We
create an Email::Sender subclass to perform the same functionality and
this also simplifies the email code with simpler envelope handling.
Bundle Email::Sender::Transport::SMTP to include fix from
https://github.com/rjbs/Email-Sender/issues/46
|
|\ \ |
|
| |/ |
|
| | |
|
|/
|
|
|
|
|
|
|
| |
Problems can have an associated defect type, that can be assigned during
an inspection. Include an admin interface for managing these types, that
can also be assigned on a per-category basis, currently available to the
Oxfordshire cobrand.
(Also include 'TM' in traffic management Exor RDI output.)
|
|\ |
|
| |
| |
| |
| |
| |
| |
| | |
The Open311 JSON output was wrapping each request parameter in a list.
This was presumably to prevent the XML output including the parameters
as attributes rather than children. A better way to fix this is to use
the NoAttr parameter to XMLout which forces them to be children.
|
|/
|
|
|
| |
If we're chugging through a list of reports, this save on a lot of
pointless statting of the upload directory which we know is there.
|
|
|
|
| |
This works better if e.g. a user stops being associated with a body.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
The interception of 404s etc is too much of an inconvenience.
|
|
|
|
|
|
|
| |
The list code was checking the photo ID given in the database existed on
disk – this shouldn't ever not be the case, and if it was, all that
would happen would be a broken image when the full photo code looks for
it (this is only for e.g. lists of reports).
|
|
|
|
|
| |
The versioning code wasn't remembering when it had found that a file did
not exist, so was checking for them each time.
|
|
|
|
|
|
|
|
|
|
|
| |
Reports in the generated Exor RDI file need to have an external_id so they can
be linked to existing enquiries (PEMs) when the RDI is imported into Exor.
There is a small window of opportunity for a report to be created, inspected and
downloaded in an RDI before it's been sent to Exor via Open311 and had an
external_id assigned. This commit closes that window by excluding reports from
the RDI that don't have an external_id.
Fixes mysociety/fixmystreetforcouncils#168
|
| |
|
|
|
|
|
|
|
|
|
|
| |
The RDI file format encapsulates information about inspections that have taken
place, and can be uploaded into Exor to create defects in bulk.
This commit adds a page to the Oxfordshire cobrand's admin allowing RDI files
to be generated and downloaded from FMS.
For mysociety/fixmystreetforcouncils#127
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rather than assigning +1 to a user's reputation every time a report is
inspected, this allows cobrands to specify which states should increment or
decrement the reputation value when a report is inspected.
The default behaviour is for reputation to never be changed, but the Oxfordshire
cobrand will increment the reputation when a report is marked as 'action
scheduled'.
For mysociety/fixmystreetforcouncils#119
|
|
|
|
|
|
| |
A report is now considered 'inspected' if its state was changed by an inspector.
Additionally, an AdminLog entry is created so the time of inspection and
inspector can be recorded.
|
| |
|
| |
|
|
|
|
|
| |
Tokens can include a 'p' field in their data to set query params for the
post-login redirect URL.
|
|
|
|
| |
If the user has a from_body and at least one category set.
|
| |
|
| |
|
| |
|
|\ |
|
| |
| |
| |
| |
| | |
Assume that if they inspect and save a report, they want
to go back to their shortlist.
|
|/ |
|
|
|
|
|
| |
Solves a minor bug where it was difficult to create a new user and immediately
assign permissions, as the page didn't show the appropriate permissions UI.
|
|
|
|
|
| |
This is to work around
https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/8572187/
|
|\ |
|
| |
| |
| |
| |
| |
| | |
If an out-of-date token was passed to check_csrf_token, then no new
token would be output on the error page because csrf_time was still
present.
|
| |
| |
| |
| |
| |
| |
| | |
This includes adding/removing reports from a user's shortlist, and
manual reordering of a shortlist with up/down buttons.
The backend code can cope with an item moving to any point in the list.
|
| | |
|
|/ |
|
|
|
|
| |
This includes a refactor of the state dropdown field into its own template for easy reuse.
|
|
|
|
|
| |
fddf7f95 broke the use of minimized JS files, because it always used an
unchanged $url in the output. Make sure it is updated if $file is.
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This allows the inspect form to be submitted when offline, with the data
saved in localStorage, the number of saved forms shown in the banner,
and the forms to be uploaded when back online.
It copes if you go back to a report after having submitted the form, and
if the back-online submission fails due to CSRF failure, retrying once
with a new token.
|
| |
| |
| |
| |
| | |
Use a list to store JavaScript files, so it can be shared
between the HTML footer and the appcache manifest.
|
| | |
|