| Commit message (Collapse) | Author | Age | Lines |
| |
|
|
|
|
|
|
|
| |
->first, as used in cd8a5702, uses the iterator, so ->next will then
only return the second onward. Instead, do the needed thing in the
first iteration of the loop. Also check the option is set as some
scripts do not set it.
|
|\ |
|
| | |
|
|/
|
|
|
|
| |
Previously if no reports were closed with an email this meant that the
lang setup never ran and you got an error when _ was called in
close_problems. So, we call the lang setup in close_problems too.
|
|
|
|
|
| |
It can be hard to see where one error stops and a new one begins in the
send reports error emails so put in a more obvious break between them.
|
|
|
|
| |
Fixes #1957
|
| |
|
|
|
|
|
|
|
|
| |
As perlsyn says, "NOTE: The behaviour of a `my`, `state`, or `our`
modified with a statement modifier conditional or loop construct (for
example, `my $x if ...`) is undefined. The value of the `my` variable
may be `undef`, any previously assigned value, or possibly anything
else."
|
| |
|
|
|
|
| |
Fixes mysociety/fixmystreet-freshdesk#24.
|
| |
|
| |
|
|
|
|
| |
So we can use this in collideoscope
|
|
|
|
|
| |
So we can use it for collideoscope which does not use a fixed end
period.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Hitherto when creating a body or ward alert on a UK site,
the MapIt area ID has been stored instead of the body ID.
This is okay for www.fixmystreet.com which for historical
reasons does have body IDs that match MapIt area IDs, but
other UK-based sites may well not. The alert lookup looks
for body ID, meaning those alerts will not work. Save the
body ID instead, plus fix some tests that were making the
same assumption.
|
|\ |
|
| |
| |
| |
| |
| | |
The inactive report script can mark matched reports as closed for updates.
This removes the update form and signing up for updates from a report page.
|
| | |
|
| | |
|
|/ |
|
|
|
|
| |
This allows a cobrand to categorise the reports however it wishes.
|
| |
|
|
|
|
|
| |
This was causing broken URLs in emails when sending reports to Bucks,
as there was no cobrand to call `base_url_for_report` on.
|
|
|
|
|
| |
Store if the report/update was created by someone using the contributed-as
dropdown, and use that information to perhaps not send report-sent emails.
|
|
|
|
|
|
|
|
| |
Per cobrand configurable option to send multiple photos over open311
instead of just a single one. Does this by sending multiple media_url
parameters in the POST body.
The default remains to send the first photo associated with a report.
|
|\ |
|
| |
| |
| |
| |
| |
| |
| | |
The Zurich code was written a long time ago, and used overriding so that
e.g. the hard-coded 'investigating' state referred to Wunsch (wish). Now
that states are stored in the database, we can create ones specially for
Zurich and use them instead. Hooray!
|
|/
|
|
| |
Add an update with each report closure.
|
| |
|
|
|
|
|
|
| |
- Send ‘report sent’ emails from cobrand’s contact address
- Don’t send email when report is made using contribute-as-other and
report_sent_confirmation_email is active.
|
| |
|
|
|
|
|
|
|
| |
It’s a little annoying to have to fiddle with the database between runs
of send-reports when debugging a stuck/failing report or working on a
new Open311 integration. This commit disables skipping of reports when
the --debug flag is used.
|
|
|
|
|
| |
has_permission_to() is called in Reports.pm and requires the cobrand to be
set on the schema. The test was manually doing this which hid the problem.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
If there was a normal email alert, and then an alert for an update with
no text (so no email should be sent), it would still try to send the
blank email, and then die because no e.g. $data{cobrand} set.
This moves the skip-blank-update check higher up, above any email
sending code.
|
| |
|
| |
|
|
|
|
|
|
| |
This includes stopping some emails being sent (moderation, alert,
questionnaire), dealing with Open311/email report sending, and
tokenised_url.
|
|
|
|
|
| |
Front page stats, update form question, list filtering, plus do not send
any questionnaires.
|
|
|
|
|
|
|
|
|
| |
If a staff user changed a problem’s state and an empty update was generated,
it was possible for alert emails to be sent with missing URLs because the
empty string in the update text was falsy and Alert.pm took the wrong path.
This fixes the problem by changing the test to defined() and includes a
regression test.
|
|
|
|
| |
Store a schema object on FixMyStreet::DB instead.
|
| |
|
|
|
|
| |
The test fixes DateTime, which wouldn't affect direct database queries.
|
|
|
|
|
|
|
| |
This makes it possible to display stats per area on /reports
Cobrands using this functionality should use the pre-dashboard
reports/index.html template and pass --areas when calling bin/update-all-reports
|
|
|
|
|
|
| |
Month strings weren't escaped in data label, and would never
match database data (using month number). Also issues displaying
current day/month in graph.
|