| Commit message (Collapse) | Author | Age | Lines |
|
|
|
| |
This makes it easier for cobrands to override nav link styles.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I can't put it better than
https://roland.codes/blog/legacy-flexbox-invisible-float-bug/ :
"Webkit’s implementation of legacy Flexbox has an strange bug that makes
flex items become invisible when they’re floated. What makes it strange
is that the flex items will still take up space in the DOM, as if they
have visibility: hidden applied.
Usually you wouldn’t use float on flex items (the spec even says that
float has no effect on them). But it’s useful for providing a fallback
layout when Flexbox isn’t supported.
Luckily I chanced on a hack that fixes the bug. All you have to do is
give the floated flex items a position, like position: relative, and
they’ll (strangely) become visible again. Another option is to use
Modernizr to only apply the float when Flexbox isn’t supported.
This bug affects legacy Flexbox in all Webkit browsers. Which includes
Chrome 20-, Safari 6-, iOS 6.1- and Android 4.3-."
|
|
|
|
|
|
|
|
| |
This improves usability on mobile devices, allowing users to pan around
the problem and see the area in more detail.
I've also changed the CSS around a bit, so we can use the
`map-fullscreen` class in other places.
|
| |
|
|
|
|
|
|
|
| |
This includes adding/removing reports from a user's shortlist, and
manual reordering of a shortlist with up/down buttons.
The backend code can cope with an item moving to any point in the list.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
The main map page elements are given `position:static` to ensure they
flow onto as many pages as required. The map image is floated to the
right, rather than wasting space at the top of the file.
We also, if the user has the inspect permission, include hidden
rrint-only metadata in the report lists.
|
|
|
|
|
|
| |
The styling applied to the nice front end multi-select dropdowns should
not be applied to the admin multi-select ones, until such time as they
are using the nice select interface too.
|
|
|
|
|
|
| |
Allow multiple asset layers, and setting of multiple asset attributes.
[Bristol] Add Bristol asset layers.
|
|
|
|
|
|
|
|
| |
Includes newest, oldest, least/most recently updated, and most comments.
The default remains the same, which is last updated on /reports, and
newest on /my and /around (the latter plus not-in-view
sorted-by-distance ones).
|
|\ |
|
| |
| |
| |
| |
| |
| | |
This lets people filter by multiple categories or states. It uses our
jQuery multi-select plugin to turn the <select multiple>s into little
overlay lists of checkboxes. HTML5 history is also supported.
|
|/ |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When this commit is finished, modern browsers will have a far less
buggy layout on .with-notes pages. The main improvements are:
1. Simplified padding on .with-notes columns, allowing us to link to
an individual column (eg: /inspect#side-report-secondary) without
the browser scrolling down to jump over the #map_sidebar padding on
desktop browsers. Making hash fragment scrolling work means we can
automatically scroll Inspectors down to the Inspect form, when they
click the Inspect button on mobile devices, without worrying about
it breaking the desktop experience.
2. Flexible .with-notes column widths, meaning the layout no longer
breaks when long sidebar content triggers a scrollbar and decreases
the usable width of the sidebar. A predefined width for #side-report
means we can make sure .shadow-wrap is the correct width, despite
its fixed position taking it out of the document flow.
We make a trade-off on mid-size screens (768-960px), of hiding the map
to keep the two-column sidebar usable. Will revisit if it turns out
this causes problems later on.
|
|
|
|
|
|
| |
Inspectors can now tick the optional “Save with a public update”
checkbox, to reveal the “Public update” textarea. This means there is
no longer a need for two separate submit buttons.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Even though FMS has had a `.btn` class for a while, styling buttons has
still been difficult, mainly because of the very opinionated base styles
applied to overpowered selectors like `input[type="submit"]`.
This commit brings the FMS styles more in line with modern frameworks
like Bootstrap – inputs and buttons are left completely unstyled by
default, with an opt-in `.btn` class to add the styles back in.
Since `.btn` is just a single class, it’s easy to override, and avoids
selector bloat like `.green-btn, button.green-btn, input.green-btn`.
|
|
|
|
|
|
|
|
| |
IDs and locations at the top, then location-related actions (including
a new “navigate to this problem” button), then status and category
inputs (since these can have an effect on how we display the rest of
the form), then any status/category-related inputs, and finally inputs
for internal details like priority and traffic management.
|
|\ |
|
| |
| |
| |
| |
| | |
The report form is now split into "Public" and "Private" sections,
with a third, matching heading, for the category_extras, if shown.
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Form input styling is mostly left up to the browser default now.
A custom border, drop-shadow, and border-radius can be applied by
adding the `.form-control` class, which standardizes the appearance
of inputs, selects, and textareas.
The core reporting form, authentication forms, local alert forms,
contact form, and questionnaire form have all been updated to use
the new `.form-control` class.
|
| |
| |
| |
| |
| |
| | |
The ticks and crosses already imply that these are things you should
and shouldn’t do. Removing the headings reduces visual clutter, and
better associates the tips with the form input directly above.
|
|/
|
|
|
|
|
|
| |
As part of this, rename "planned reports" to "shortlist".
The `.segmented-control` component now supports basic usage (as in the
admin report actions menu bar) and usage with hidden radio inputs and
labels (as on the report questionnaire page).
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Users with the `report_inspect` permission can click a new 'inspect' button on a
report page to input more detailed problem information into a new form that
appears in a column alongside the report detail.
- Inspector data is stored in problem's 'extra' field
- Report category/state can be edited
- Location can be changed by dragging the pin or HTML5 geolocation
(Factored out Zurich admin pin drag into own function)
For mysociety/fixmystreetforcouncils#22
|
|
|
|
|
| |
Remove unused code that is same as upstream (it was added when the map
middle didn't match the visible middle), and the world button.
|
|
|
|
|
| |
No need to use old OpenLayers PanZoom defaults, or load images we don't
want to use.
|
| |
|
|
|
|
|
| |
This prevents scrolling when we're on the full screen map, and makes
sure the map is back in view when it is shown.
|
|\ |
|
| |
| |
| |
| |
| | |
Having them as SDK-included buttons causes issues with the ajax
report pull-ins, plus Firefox doesn't like them being hidden.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Include URL changing, using history.pushState.
Show a larger marker icon for the selected report.
Make sure title is updated, and correct sub_map_links are shown.
The /report/new template is now wrapped in a <div id="side-form">
rather than <div id="side"> for consistency with the /around page,
which keeps display_all_reports_in_area() simpler, because it can
always assume "#side" means "list of reports".
|
| |
| |
| |
| |
| | |
On mobile, the notes in `#report-a-problem-sidebar` are hidden by
default, and can be toggled using the `.rap-notes-trigger`.
|
| | |
|
|/
|
|
|
| |
Tidy up use of absolute URLs when in the admin.
Have the 404 handler spot static files in admin as a fallback.
|
|\ |
|
| |
| |
| |
| |
| | |
Show map, break into two columns, fix display of sent time after
clicking "Mark as sent", tidy up labels.
|
|/
|
|
|
|
|
|
|
|
|
|
| |
`.form-box--logged-in-name` has no preceding heading, which meant the
grey box background was colliding with whatever content happened to go
before it.
We add some margin, and while we’re at it, remove the extra margin-top
on first-child labels (unnecessary, since .form-boxes have their own
padding) and tidy up the syntax of the .form-box rule set.
Fixes #1418.
|
| |
|
|
|
|
|
| |
The 'cross' at mobile widths was not displaying, and the icon was not
changing to a down arrow at larger widths.
|
| |
|
|\ |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This simplifies the page layout and code. We add a new #map_sidebar for
sidebar positioning, and a $mappage-header-height (defaulting to 4em)
variable. We no longer need:
* position_map_box;
* map_fix;
* special visual centre calculation; or
* custom pan zoom positioning.
As the sidebar now scrolls by itself and nothing can extend outside:
* The big-green-banner is set to 100% width (with negative margins no
longer required);
* For cobrands that have an overhanging sidebar (e.g. Zurich), we add
a .with-notes variant that adds a second column to the sidebar,
perfect for containing secondary notes about the form.
The resizing of the banner also required some tweaking to the size of
the chevron-white SVG images.
Update the $.fn.drawer() method for the new layout. Works well in IE7+8,
and degrades gracefully in IE6.
For IE7, we remove the existing z-index hacks, and put a new, simpler,
one in, and fix a CSS bug that was hiding the map.
Various cobrands are updated to adapt to the changes.
|
| |
| |
| |
| |
| | |
We previously used !important to override them in the CSS, but better to
prevent them being set in the JavaScript in the first place.
|
|/
|
|
|
|
|
|
| |
Move to using libsass via CSS::Sass, and stop using compass, supplying
any used mixins directly. This removes the need for any ruby/gem based
installation, and greatly increases the speed of compilation. make_css
is also enhanced, bringing in the file monitoring previously done by a
separate script and improving its dependency monitoring.
|