1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
|
#!/usr/bin/perl
# script for absobring incoming Open311 service request POSTs and
# passing them into Bentley EXOR backend via create_enquiry stored
# procedure.
#
# mySociety: http://code.fixmystreet.com/
#-----------------------------------------------------------------
use strict;
use CGI;
use Time::Piece;
use DBI;
use DBD::Oracle qw(:ora_types);
### for local testing (no Oracle):
###use constant { ORA_VARCHAR2=>1, ORA_DATE=>1, ORA_NUMBER=>1};
###################################################################
# Config file: values in the config file override any values set
# in the code below for the following things:
#
# host: SXX-SAN-FOO_BAR
# sid: FOOBAR
# port: 1531
# username: foo
# password: FooBar
# testing: 0
#
# Absence of the config file fails silently in case you really are
# using values directly set in this script.
#------------------------------------------------------------------
my $CONFIG_FILENAME = "/usr/local/etc/fixmystreet.config";
use constant {
GENERAL_SERVICE_ERROR => 400,
CODE_OR_ID_NOT_FOUND => 404,
CODE_OR_ID_NOT_PROVIDED => 400,
BAD_METHOD => 405,
FATAL_ERROR => 500
};
my $DB_SERVER_NAME = 'FOO';
my $DB_HOST = $DB_SERVER_NAME; # did this just in case we need to add more to the name (e.g, domain)
my $DB_PORT = '1531';
my $ORACLE_SID = 'FOOBAR';
my $USERNAME = 'FIXMYSTREET';
my $PASSWORD = 'XXX';
my $STORED_PROC_NAME = 'PEM.create_enquiry';
# NB can override this setting in the config file!
# 'ruthless' removes everything (i.e. all POSIX control chars)
# 'desc' removes everything, but keeps tabs and newlines in the 'description' field, where they matter
# 'normal' keeps tabs and newlines
my $STRIP_CONTROL_CHARS = 'normal';
my $TESTING_WRITE_TO_FILE = 0; # write to file instead of DB
my $OUT_FILENAME = "fms-test.txt";
my $TEST_SERVICE_DISCOVERY = 0; # switch to 1 to run service discovery, which confirms the DB connection at least
# Config file overrides existing values for these, if present:
if ($CONFIG_FILENAME && open(CONF, $CONFIG_FILENAME)) {
while (<CONF>) {
next if /^#/;
if (/^\s*password:\s*(\S+)\s*$/i) {
$PASSWORD = $1;
} elsif (/^\s*sid:\s*(\S+)\s*$/i) {
$ORACLE_SID = $1;
} elsif (/^\s*username:\s*(\S+)\s*$/i) {
$USERNAME = $1;
} elsif (/^\s*port:\s*(\S+)\s*$/i) {
$DB_PORT = $1;
} elsif (/^\s*host:\s*(\S+)\s*$/i) {
$DB_HOST = $1;
} elsif (/^\s*testing:\s*(\S+)\s*$/i) {
$TESTING_WRITE_TO_FILE = $1;
} elsif (/^\s*test-service-discovery:\s*(\S+)\s*$/i) {
$TEST_SERVICE_DISCOVERY = $1;
} elsif (/^\s*strip-control-chars:\s*(\S+)\s*$/i) {
$STRIP_CONTROL_CHARS = lc $1;
}
}
}
# assuming Oracle environment is happily set already, don't need these:
# my $ORACLE_HOME = "/app/oracle/product/11.2.0/db_1";
# $ENV{ORACLE_HOME} = $ORACLE_HOME;
# $ENV{ORACLE_SID} = $ORACLE_SID;
# $ENV{PATH} ="$ORACLE_HOME/bin";
# $ENV{LD_LIBRARY_PATH}="$ORACLE_HOME/lib";
my %PEM_BOUND_VAR_TYPES = get_pem_field_types();
my $ERR_MSG = 'error'; # unique key in data hash
# incoming (Open311, from FMS) field names
# note: attribute[*] are being sent by FMS explicitly as attributes for Oxfordshire
my %F = (
'ACCOUNT_ID' => 'account_id',
'ADDRESS_ID' => 'address_id',
'ADDRESS_STRING' => 'address_string',
'API_KEY' => 'api_key',
'DESCRIPTION' => 'description',
'DEVICE_ID' => 'device_id',
'EASTING' => 'attribute[easting]',
'EMAIL' => 'email',
'FIRST_NAME' => 'first_name',
'FMS_ID' => 'attribute[external_id]',
'LAST_NAME' => 'last_name',
'LAT' => 'lat',
'LONG' => 'long',
'MEDIA_URL' => 'media_url',
'NEAREST_STREET' => 'attribute[nearest_street]',
'NORTHING' => 'attribute[northing]',
'PHONE' => 'phone',
'POSTCODE' => 'attribute[postcode]',
'REQUESTED_DATETIME' => 'requested_datetime',
'SERVICE_CODE' => 'service_code',
'STATUS' => 'status',
);
my $req = new CGI;
# normally, POST requests are inserting service requests
# and GET requests are for returning service requests, although OCC aren't planning on
# using that (it's part of the Open311 spec).
# So actually the service discovery is more useful, so send in a 'services' param
# to see that.
#
# But for testing the db connection, set $TEST_SERVICE_DISCOVERY so that
# *all* requests simply do a service discovery by setting (possibly via the config file)
if ($TEST_SERVICE_DISCOVERY) {
get_service_discovery($req); # to test
}elsif ($ENV{'REQUEST_METHOD'} eq "POST") {
post_service_request($req);
} elsif ($req -> param('services')) {
get_service_discovery($req);
} else {
### # allow a GET to make an insert, for testing (from the commandnd line!)
### my $fixme = get_FAKE_INSERT($req); print "Returned $fixme\n";
get_service_requests($req);
}
#----------------------------------------------------
# post_service_request
# accepts an incoming service request
# If everything goes well, it puts it in the database and
# returns the PEM ID to the caller
#----------------------------------------------------
sub post_service_request {
my $req = shift;
my %data;
my $pem_id = 0;
foreach (values %F) {
$data{$_} = $req -> param($_);
$data{$_} =~ s/^\s+|\s+$//g; # trim
if ($STRIP_CONTROL_CHARS) {
if ($STRIP_CONTROL_CHARS eq 'ruthless') {
$data{$_} =~ s/[[:cntrl:]]/ /g; # strip all control chars, simples
} elsif ($STRIP_CONTROL_CHARS eq 'desc') {
if ($_ eq 'DESCRIPTION') {
$data{$_} =~ s/[^\t\n[:^cntrl:]]/ /g; # leave tabs and newlines
} else {
$data{$_} =~ s/[[:cntrl:]]/ /g; # strip all control chars, simples
}
} else {
$data{$_} =~ s/[^\t\n[:^cntrl:]]/ /g; # leave tabs and newlines
}
}
}
error_and_exit(CODE_OR_ID_NOT_PROVIDED, "missing service code (Open311 requires one)")
unless $data{$F{SERVICE_CODE}};
error_and_exit(GENERAL_SERVICE_ERROR, "the service code you provided ($data{$F{SERVICE_CODE}}) was not recognised by this server")
unless service_exists($data{$F{SERVICE_CODE}});
error_and_exit(GENERAL_SERVICE_ERROR, "no address or long-lat provided")
unless ( (is_longlat($data{$F{LONG}}) && is_longlat($data{$F{LAT}})) || $data{$F{ADDRESS_STRING}} );
if ($TESTING_WRITE_TO_FILE) {
$pem_id = dump_to_file(\%data);
} else {
$pem_id = insert_into_pem(\%data);
}
if (! $pem_id) {
error_and_exit(FATAL_ERROR, $data{$ERR_MSG} || "failed to get PEM ID");
} else {
print <<XML;
Content-type: text/xml
<?xml version="1.0" encoding="utf-8"?>
<service_requests>
<request>
<service_request_id>$pem_id</service_request_id>
</request>
</service_requests>
XML
}
}
#------------------------------------------------------------------
# error_and_exit
# args: HTTP status code, error message
# Sends out the HTTP status code and message
# and temrinates execution
#------------------------------------------------------------------
sub error_and_exit {
my ($status, $msg) = @_;
print "Status: $status $msg\n\n$msg\n";
exit;
}
#------------------------------------------------------------------
# is_longlat
# returns true if this looks like a long/lat value
#------------------------------------------------------------------
sub is_longlat {
return $_[0] =~ /^-?\d+\.\d+$/o? 1 : 0;
}
#------------------------------------------------------------------
# get_db_connection
# no args: uses globals, possibly read from config
# returns handle for the connection (otherwise terminates)
#------------------------------------------------------------------
sub get_db_connection {
return DBI->connect( "dbi:Oracle:host=$DB_HOST;sid=$ORACLE_SID;port=$DB_PORT", $USERNAME, $PASSWORD )
or error_and_exit(FATAL_ERROR, "failed to connect to database: " . $DBI::errstr, "");
}
#------------------------------------------------------------------
# service_exists
# lookup the service code, to check that it exists
# SELECT det_code, det_name FROM higatlas.doc_enquiry_types WHERE
# det_dtp_code = 'REQS' AND det_dcl_code ='SERV' AND det_con_id=1
# Actually, FMS is expected to be sending good codes because they
# come from here anyway, and are expected to be stable. But could
# cache and check... probably overkill since DB insert will probably
# throw the error anyway.
#------------------------------------------------------------------
sub service_exists {
my $service_code = shift;
return 1;
}
#------------------------------------------------------------------
# dump_to_file
# args: ref to hash of data
# for testing, log the incoming data into a local file
# NB throws a fatal error
#------------------------------------------------------------------
sub dump_to_file {
my $h = shift; # href to data hash
if (open (OUTFILE, ">$OUT_FILENAME")) {
print OUTFILE "Data dump: " . gmtime() . "\n" . '-' x 64 . "\n\n";
foreach (sort keys %$h) {
print OUTFILE "$_ => " . $$h{$_} . "\n";
}
print OUTFILE "\n\n" . '-' x 64 . "\n[end]\n";
close OUTFILE;
$$h{$ERR_MSG} = "NB did not write to DB (see $OUT_FILENAME instead: switch off \$TESTING_WRITE_TO_FILE to stop this)";
} else {
$$h{$ERR_MSG} = "failed to write to outfile ($!)";
}
return 0; # test always throws an error so no risk of production confusion!
}
#------------------------------------------------------------------
# insert_into_pem
# args: hashref to data hash
# returns PEM id of the new record (or passes an error message
# into the data hash if no id is available)
#------------------------------------------------------------------
sub insert_into_pem {
my $h = shift; # href to data hash
my $dbh = get_db_connection();
my $pem_id;
my $error_value;
my $error_product;
# set specifc vars up where further processing on them might be needed:
my $undef = undef;
my $address = $$h{$F{ADDRESS_STRING}};
my $status = $$h{$F{STATUS}};
my $service_code = $$h{$F{SERVICE_CODE}};
my $description = $$h{$F{DESCRIPTION}};
my $media_url = $$h{$F{MEDIA_URL}};
my $postcode = uc $$h{$F{POSTCODE}}; # postcode must be in upper case...
$postcode =~s/\s+//g; # ...and no spaces in postcode
if ($media_url) {
$description .= ($STRIP_CONTROL_CHARS ne 'ruthless'? "\n\n":" ") . "Photo: $media_url";
}
my $sth = $dbh->prepare(q#
BEGIN
PEM.create_enquiry(
ce_cat => :ce_cat,
ce_class => :ce_class,
ce_forename => :ce_forename,
ce_surname => :ce_surname,
ce_contact_type => :ce_contact_type,
ce_postcode => :ce_postcode,
ce_street => :ce_street,
ce_work_phone => :ce_work_phone,
ce_email => :ce_email,
ce_description => :ce_description,
ce_enquiry_type => :ce_enquiry_type,
ce_source => :ce_source,
ce_incident_datetime => to_Date(:ce_incident_datetime,'YYYY-MM-DD HH24:MI'),
ce_x => :ce_x,
ce_y => :ce_y,
ce_doc_reference => :ce_doc_reference,
ce_status_code => :ce_status_code,
ce_compl_user_type => :ce_compl_user_type,
error_value => :error_value,
error_product => :error_product,
ce_doc_id => :ce_doc_id);
END;
#);
my %bindings;
# comments here are suggested values
# fixed values
$bindings{":ce_cat"} = 'REQS'; # or REQS ?
$bindings{":ce_class"} = 'SERV'; # 'FRML' ?
$bindings{":ce_contact_type"} = 'ENQUIRER'; # 'ENQUIRER'
$bindings{":ce_status_code"} = 'RE'; # RE=received (?)
$bindings{":ce_compl_user_type"}= 'USER'; # 'USER'
# ce_incident_datetime is *not* an optional param, but FMS isn't sending it at the moment
$bindings{":ce_incident_datetime"}=$$h{$F{REQUESTED_DATETIME}} || Time::Piece->new->strftime('%Y-%m-%d %H:%M');
# especially FMS-specific:
$bindings{":ce_source"} = "FMS"; # important, and specific to this script!
$bindings{":ce_doc_reference"} = $$h{$F{FMS_ID}}; # FMS id
$bindings{":ce_enquiry_type"} = $service_code;
# incoming data
$bindings{":ce_x"} = $$h{$F{EASTING}};
$bindings{":ce_y"} = $$h{$F{NORTHING}};
$bindings{":ce_forename"} = substr($$h{$F{FIRST_NAME}}, 0, 30); # 'CLIFF'
$bindings{":ce_surname"} = substr($$h{$F{LAST_NAME}}, 0, 30); # 'STEWART'
$bindings{":ce_work_phone"} = substr($$h{$F{PHONE}}, 0, 25); # '0117 600 4200'
$bindings{":ce_email"} = substr($$h{$F{EMAIL}}, 0, 50); # 'info@exor.co.uk'
$bindings{":ce_description"} = substr($description, 0, 2000); # 'Large Pothole'
$bindings{":ce_street"} = substr($$h{$F{NEAREST_STREET}}, 0, 80); # calculated/human postcode
$bindings{":ce_postcode"} = substr($postcode, 0, 8); # calculated nearest street
foreach my $name (sort keys %bindings) {
next if grep {$name eq $_} (':error_value', ':error_product', ':ce_doc_id'); # return values (see below)
$sth->bind_param(
$name,
$bindings{$name},
$PEM_BOUND_VAR_TYPES{$name} || ORA_VARCHAR2
);
}
# return values are bound explicitly here:
$sth->bind_param_inout(":error_value", \$error_value, 12); #> l_ERROR_VALUE # number
$sth->bind_param_inout(":error_product", \$error_product, 10); #> l_ERROR_PRODUCT (will always be 'DOC')
$sth->bind_param_inout(":ce_doc_id", \$pem_id, 12); #> l_ce_doc_id # number
# not used, but from the example docs, for reference
# $sth->bind_param(":ce_contact_title", $undef); # 'MR'
# $sth->bind_param(":ce_postcode", $undef); # 'BS11EJ' NB no spaces, upper case
# $sth->bind_param(":ce_building_no", $undef); # '1'
# $sth->bind_param(":ce_building_name", $undef); # 'CLIFTON HEIGHTS'
# $sth->bind_param(":ce_street", $undef); # 'HIGH STREET'
# $sth->bind_param(":ce_town", $undef); # 'BRSITOL'
# $sth->bind_param(":ce_location", $undef); # 'Outside Flying Horse Public House'
# $sth->bind_param(":ce_enquiry_type", $undef); # 'CD' , ce_source => 'T'
# $sth->bind_param(":ce_cpr_id", $undef); # '5' (priority)
# $sth->bind_param(":ce_rse_he_id", $undef); #> nm3net.get_ne_id('1200D90970/09001','L')
# $sth->bind_param(":ce_compl_target", $undef); # '08-JAN-2004'
# $sth->bind_param(":ce_compl_corresp_date",$undef); # '02-JAN-2004'
# $sth->bind_param(":ce_compl_corresp_deliv_date", $undef); # '02-JAN-2004'
# $sth->bind_param(":ce_resp_of", $undef); # 'GBOWLER'
# $sth->bind_param(":ce_hct_vip", $undef); # 'CO'
# $sth->bind_param(":ce_hct_home_phone", $undef); # '0117 900 6201'
# $sth->bind_param(":ce_hct_mobile_phone", $undef); # '07111 1111111'
# $sth->bind_param(":ce_compl_remarks", $undef); # remarks (notes) max 254 char
$sth->execute();
$dbh->disconnect;
# if error, maybe need to look it up:
# error_value is the index HER_NO in table HIG_ERRORS, which has messages
# actually err_product not helpful (wil always be "DOC")
$$h{$ERR_MSG} = "$error_value $error_product" if ($error_value || $error_product);
return $pem_id;
}
#------------------------------------------------------------------
# get_service_requests
# Strictly speaking, Open311 would expect the GET request for service
# requests to respond with all service requests (within a specified
# period). But as we're not using that, do a service discovery
# instead.
#------------------------------------------------------------------
sub get_service_requests {
# error_and_exit(BAD_METHOD, "sorry, currently only handling incoming Open311 service requests: use POST method");
get_service_discovery(); # for now
}
#------------------------------------------------------------------
# get_FAKE_INSERT
# for testing off command line, force the data
#------------------------------------------------------------------
sub get_FAKE_INSERT {
my %fake_data = (
$F{'DESCRIPTION'} => 'Testing, description',
$F{'EASTING'} => '45119',
$F{'EMAIL'} => 'email@example.com',
$F{'FIRST_NAME'} => 'Dave',
$F{'FMS_ID'} => '1012',
$F{'LAST_NAME'} => 'Test',
$F{'LAT'} => '51.756741605999',
$F{'LONG'} => '-1.2596387532192',
$F{'NORTHING'} => '206709',
$F{'SERVICE_CODE'} => 'OT',
$F{'MEDIA_URL'} => 'http://www.example.com/pothole.jpg',
$F{'POSTCODE'} => 'OX20 1SZ',
$F{'NEAREST_STREET'} => 'Testit Street'
);
return insert_into_pem(\%fake_data)
}
#------------------------------------------------------------------
# get_service_discovery
# Although not really implementing this, use it as a test to read the
# db and confirm connectivity.
#------------------------------------------------------------------
sub get_service_discovery {
my $dbh = get_db_connection();
my $ary_ref = $dbh->selectall_arrayref(qq(select det_code, det_name from higatlas.doc_enquiry_types where det_dtp_code = 'REQS' AND det_dcl_code='SERV' and det_con_id=1));
# rough and ready XML dump now (should use XML Simple to build/escape properly!)
my $xml = "";
foreach my $row(@{$ary_ref}) {
if (defined $row) {
my ($code, $name) = @$row;
$xml.= <<XML;
<service>
<service_code>$code</service_code>
<metadata>false</metadata>
<type>realtime</type>
<keywords/>
<group/>
<service_name>$name</service_name>
<description/>
</service>
XML
}
}
print <<XML;
Content-type: text/xml
<?xml version="1.0" encoding="utf-8"?>
<services>
$xml
</services>
XML
}
#------------------------------------------------------------------
# get_pem_field_types
# return hash of types by field name: any not explicitly set here
# can be defaulted to VARCHAR2
#------------------------------------------------------------------
sub get_pem_field_types {
return (
':ce_incident_datetime' => ORA_DATE,
':ce_x' => ORA_NUMBER,
':ce_y' => ORA_NUMBER,
':ce_date_expires' => ORA_DATE,
':ce_issue_number' => ORA_NUMBER,
':ce_status_date' => ORA_DATE,
':ce_compl_ack_date' => ORA_DATE,
':ce_compl_peo_date' => ORA_DATE,
':ce_compl_target' => ORA_DATE,
':ce_compl_complete' => ORA_DATE,
':ce_compl_from' => ORA_DATE,
':ce_compl_to' => ORA_DATE,
':ce_compl_corresp_date' => ORA_DATE,
':ce_compl_corresp_deliv_date' => ORA_DATE,
':ce_compl_no_of_petitioners' => ORA_NUMBER,
':ce_compl_est_cost' => ORA_NUMBER,
':ce_compl_adv_cost' => ORA_NUMBER,
':ce_compl_act_cost' => ORA_NUMBER,
':ce_compl_follow_up1' => ORA_DATE,
':ce_compl_follow_up2' => ORA_DATE,
':ce_compl_follow_uo3' => ORA_DATE,
':ce_date_time_arrived' => ORA_DATE,
':error_value' => ORA_NUMBER,
':ce_doc_id' => ORA_NUMBER,
)
}
|