1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
|
use FixMyStreet::Test;
use DateTime;
my $db = FixMyStreet::DB->schema;
my $body = $db->resultset('Body')->create({ name => 'ExtraTestingBody' });
my $serial = 1;
sub get_test_contact {
my $extra = shift;
my $contact = $db->resultset('Contact')->create({
category => "Testing ${serial}",
body => $body,
email => 'test@example.com',
state => 'confirmed',
editor => 'test script',
note => 'test script',
whenedited => DateTime->now(),
$extra ? ( extra => $extra ) : (),
});
$serial++;
return $contact;
}
subtest 'Old list layout transparently upgraded' => sub {
subtest 'layout' => sub {
my $contact = get_test_contact([]);
is_deeply $contact->get_extra(), { _fields => [] }, 'transparently upgraded to a hash';
};
subtest 'extra fields' => sub {
my $contact = get_test_contact([]);
is_deeply $contact->get_extra_fields(), [], 'No extra fields';
my @fields = ( { a => 1 }, { b => 2 } );
$contact->set_extra_fields(@fields);
is_deeply $contact->extra, { _fields => \@fields }, 'extra fields set...';
$contact->update;
$contact->discard_changes;
is_deeply $contact->extra, { _fields => \@fields }, '...and retrieved';
is_deeply $contact->get_extra_fields(), \@fields, 'extra fields returned';
};
subtest 'metadata' => sub {
my $contact = get_test_contact([]);
is_deeply $contact->get_extra_metadata, {}, 'No extra metadata';
$contact->set_extra_metadata('foo' => 'bar');
is $contact->get_extra_metadata('foo'), 'bar', 'extra metadata set...';
$contact->update;
$contact->discard_changes;
is $contact->get_extra_metadata('foo'), 'bar', '... and retrieved';
is_deeply $contact->get_extra_metadata, { foo => 'bar' }, 'No extra metadata';
};
};
subtest 'Default hash layout' => sub {
subtest 'layout' => sub {
my $contact = get_test_contact();
is_deeply $contact->get_extra(), {}, 'default layout is hash';
};
subtest 'extra fields' => sub {
my $contact = get_test_contact();
is_deeply $contact->get_extra_fields(), [], 'No extra fields';
my @fields = ( { a => 1 }, { b => 2 } );
$contact->set_extra_fields(@fields);
is_deeply $contact->get_extra_fields, \@fields, 'extra fields set...';
$contact->update;
$contact->discard_changes;
is_deeply $contact->get_extra_fields(), \@fields, '... and returned';
is_deeply $contact->extra, { _fields => \@fields }, '(sanity check layout)';
};
subtest 'updating extra field' => sub {
my $contact = get_test_contact();
my @fields = ( { code => 'ABC', description => 'ABC', variable => 'false', }, { code => 'DEF', description => 'DEF', variable => 'true' } );
$contact->set_extra_fields(@fields);
is_deeply $contact->get_extra_fields, \@fields, 'extra fields set...';
my $new_field = { code => 'ABC', description => 'XYZ', variable => 'false' };
$contact->update_extra_field($new_field);
$fields[0] = $new_field;
is_deeply $contact->get_extra_fields, \@fields, 'extra fields changed';
$new_field = { code => 'GHI', description => 'GHI', variable => 'false' };
$contact->update_extra_field($new_field);
push @fields, $new_field;
is_deeply $contact->get_extra_fields, \@fields, 'extra fields changed';
};
subtest 'removing extra field' => sub {
my $contact = get_test_contact();
my @fields = ( { code => 'ABC', description => 'ABC', variable => 'false', }, { code => 'DEF', description => 'DEF', variable => 'true' } );
$contact->set_extra_fields(@fields);
is_deeply $contact->get_extra_fields, \@fields, 'extra fields set...';
$contact->remove_extra_field('DEF');
pop @fields;
is_deeply $contact->get_extra_fields(), \@fields, 'extra field removed';
};
subtest 'metadata' => sub {
my $contact = get_test_contact();
is_deeply $contact->get_extra_metadata, {}, 'No extra metadata';
$contact->set_extra_metadata('foo' => 'bar');
is $contact->get_extra_metadata('foo'), 'bar', 'extra metadata set...';
$contact->update;
$contact->discard_changes;
is $contact->get_extra_metadata( 'foo'), 'bar', '... and retrieved';
is_deeply $contact->get_extra_metadata, { foo => 'bar' }, 'No extra metadata';
$contact->unset_extra_metadata('foo');
is $contact->get_extra_metadata('foo'), undef, 'extra metadata now unset';
$contact->update;
$contact->discard_changes;
is $contact->get_extra_metadata('foo'), undef, '... after retrieval';
};
};
subtest 'Get named field values' => sub {
my $user = $db->resultset('User')->create({
email => 'test-moderation@example.com',
email_verified => 1,
name => 'Test User'
});
my $report = $db->resultset('Problem')->create(
{
postcode => 'BR1 3SB',
bodies_str => "",
areas => "",
category => 'Other',
title => 'Good bad good',
detail => 'Good bad bad bad good bad',
used_map => 't',
name => 'Test User 2',
anonymous => 'f',
state => 'confirmed',
lang => 'en-gb',
service => '',
cobrand => 'default',
latitude => '51.4129',
longitude => '0.007831',
user_id => $user->id,
});
$report->push_extra_fields(
{
name => "field1",
description => "This is a test field",
value => "value 1",
},
{
name => "field 2",
description => "Another test",
value => "this is a test value",
}
);
is $report->get_extra_field_value("field1"), "value 1", "field1 has correct value";
is $report->get_extra_field_value("field 2"), "this is a test value", "field 2 has correct value";
$report->delete;
$user->delete;
};
subtest 'Get named fields' => sub {
my $user = $db->resultset('User')->create({
email => 'test-moderation@example.com',
email_verified => 1,
name => 'Test User'
});
my $report = $db->resultset('Problem')->create(
{
postcode => 'BR1 3SB',
bodies_str => "",
areas => "",
category => 'Other',
title => 'Good bad good',
detail => 'Good bad bad bad good bad',
used_map => 't',
name => 'Test User 2',
anonymous => 'f',
state => 'confirmed',
lang => 'en-gb',
service => '',
cobrand => 'default',
latitude => '51.4129',
longitude => '0.007831',
user_id => $user->id,
});
my @fields = ({
name => "field1",
description => "This is a test field",
value => "value 1",
},
{
code => "field 2",
description => "Another test",
value => "this is a test value",
});
$report->push_extra_fields(@fields);
is_deeply $report->get_extra_field(name => "field1"), $fields[0], "field1 has correct value";
is_deeply $report->get_extra_field(code => "field 2"), $fields[1], "field 2 has correct value";
is $report->get_extra_field(name => "field 2"), undef, "returns undef if no match";
};
done_testing();
|
