aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGareth Rees <gareth@mysociety.org>2014-10-01 13:00:01 +0100
committerLouise Crow <louise.crow@gmail.com>2014-12-22 16:26:17 +0000
commit136cb0743594b91a335686aa7d942b8017392b11 (patch)
tree6c8c6d8117065b5be52eb4c0918c0cd9c00777c9
parent316762130b9da0b7af00896fee692011aaaa0ede (diff)
Fix unvalidated redirects
-rw-r--r--app/controllers/track_controller.rb2
-rw-r--r--app/controllers/user_controller.rb4
2 files changed, 3 insertions, 3 deletions
diff --git a/app/controllers/track_controller.rb b/app/controllers/track_controller.rb
index 83700a55b..144f4d55a 100644
--- a/app/controllers/track_controller.rb
+++ b/app/controllers/track_controller.rb
@@ -214,7 +214,7 @@ class TrackController < ApplicationController
track_thing.destroy
end
- redirect_to params[:r]
+ redirect_to URI.parse(params[:r]).path
end
diff --git a/app/controllers/user_controller.rb b/app/controllers/user_controller.rb
index f23343ddb..f63d6a508 100644
--- a/app/controllers/user_controller.rb
+++ b/app/controllers/user_controller.rb
@@ -256,7 +256,7 @@ class UserController < ApplicationController
def signout
self._do_signout
if params[:r]
- redirect_to params[:r]
+ redirect_to URI.parse(params[:r]).path
else
redirect_to :controller => "general", :action => "frontpage"
end
@@ -596,7 +596,7 @@ class UserController < ApplicationController
end
@user.receive_email_alerts = params[:receive_email_alerts]
@user.save!
- redirect_to params[:came_from]
+ redirect_to URI.parse(params[:came_from]).path
end
private