diff options
author | Gareth Rees <gareth@mysociety.org> | 2014-10-30 13:01:35 +0000 |
---|---|---|
committer | Gareth Rees <gareth@mysociety.org> | 2014-11-11 16:02:18 +0000 |
commit | 29552f13f7340875e519b1e017349cb3c6d705a6 (patch) | |
tree | 12854d6116574d091038ffb93730ded273fef27e | |
parent | e12ef04af94676ee7c308233c6904da74a4a7ac9 (diff) |
Refactor request/_search_ahead partial
Each instead of for
Unless instead of if !
.any? instead of size > 0
Line length
-rw-r--r-- | app/views/request/_search_ahead.html.erb | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/app/views/request/_search_ahead.html.erb b/app/views/request/_search_ahead.html.erb index 1e65a5458..7120f3862 100644 --- a/app/views/request/_search_ahead.html.erb +++ b/app/views/request/_search_ahead.html.erb @@ -1,10 +1,14 @@ <div id="request_search_ahead_results"> - <% if !@xapian_requests.nil? %> - <% if @xapian_requests.results.size > 0 %> + <% unless @xapian_requests.nil? %> + + <% if @xapian_requests.results.any? %> <h3><%= _("Possibly related requests:") %></h3> <% end %> - <% for result in @xapian_requests.results %> - <%= render :partial => 'request/request_listing_short_via_event', :locals => { :event => result[:model], :info_request => result[:model].info_request } %> + + <% @xapian_requests.results.each do |result| %> + <%= render :partial => 'request/request_listing_short_via_event', + :locals => { :event => result[:model], + :info_request => result[:model].info_request } %> <% end %> <p> |