Add specs to AboutMeValidator

2 files changed, 59 insertions, 0 deletions

diff --git a/app/controllers/user_controller.rb b/app/controllers/user_controller.rb
index 56f42891d..32b6978ea 100644
--- a/app/controllers/user_controller.rb
+++ b/app/controllers/user_controller.rb
@@ -569,6 +569,12 @@ class UserController < ApplicationController
             return
         end
 
+        if @user.banned?
+          flash[:error] = _('Banned users cannot edit their profile')
+          redirect_to set_profile_about_me_path
+          return
+        end
+
         @about_me = AboutMeValidator.new(params[:about_me])
         if !@about_me.valid?
             render :action => 'set_profile_about_me'
diff --git a/spec/models/about_me_validator_spec.rb b/spec/models/about_me_validator_spec.rb
new file mode 100644
index 000000000..5610cead8
--- /dev/null
+++ b/spec/models/about_me_validator_spec.rb
@@ -0,0 +1,53 @@
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+
+describe AboutMeValidator do
+
+  describe :new do
+
+    it 'sets each supported attribute on the instance' do
+      params = { :about_me => 'My description' }
+      validator = AboutMeValidator.new(params)
+      expect(validator.about_me).to eq('My description')
+    end
+
+  end
+
+  describe :valid? do
+
+    it 'is valid if about_me is =< 500' do
+      params = { :about_me => 'a'*500 }
+      validator = AboutMeValidator.new(params)
+      expect(validator).to be_valid
+    end
+
+    it 'is valid if about_me is blank' do
+      params = { :about_me => '' }
+      validator = AboutMeValidator.new(params)
+      expect(validator).to be_valid
+    end
+
+    it 'is valid if about_me is nil' do
+      params = { :about_me => nil }
+      validator = AboutMeValidator.new(params)
+      expect(validator).to be_valid
+    end
+
+    it 'is invalid if about_me is > 500' do
+      params = { :about_me => 'a'*501 }
+      validator = AboutMeValidator.new(params)
+      expect(validator).to have(1).error_on(:about_me)
+    end
+
+  end
+
+  describe :about_me do
+
+    it 'has an attribute accessor' do
+      params = { :about_me => 'My description' }
+      validator = AboutMeValidator.new(params)
+      expect(validator.about_me).to eq('My description')
+    end
+
+  end
+
+end