Rewrite spec to reflect delegation of low-level mail methods to mail handler, use mail handler methods.

2 files changed, 17 insertions, 29 deletions

diff --git a/app/models/incoming_message.rb b/app/models/incoming_message.rb
index 0ebf0017d..464910d01 100644
--- a/app/models/incoming_message.rb
+++ b/app/models/incoming_message.rb
@@ -89,11 +89,8 @@ class IncomingMessage < ActiveRecord::Base
     # Return false if for some reason this is a message that we shouldn't let them reply to
     def _calculate_valid_to_reply_to
         # check validity of email
-        if empty_from_field?
-            return false
-        end
         email = self.from_email
-        if !MySociety::Validate.is_valid_email(email)
+        if email.nil? || !MySociety::Validate.is_valid_email(email)
             return false
         end
 
@@ -106,10 +103,10 @@ class IncomingMessage < ActiveRecord::Base
         if !prefix.nil? && prefix.downcase.match(/^(postmaster|mailer-daemon|auto_reply|do.?not.?reply|no.reply)$/)
             return false
         end
-        if !self.mail['return-path'].nil? && self.mail['return-path'].addr == "<>"
+        if MailHandler.empty_return_path?(self.mail)
             return false
         end
-        if !self.mail['auto-submitted'].nil?
+        if !MailHandler.get_auto_submitted(self.mail).nil?
             return false
         end
         return true
diff --git a/spec/models/incoming_message_spec.rb b/spec/models/incoming_message_spec.rb
index fdbcd1e23..7afbacc9e 100644
--- a/spec/models/incoming_message_spec.rb
+++ b/spec/models/incoming_message_spec.rb
@@ -194,59 +194,50 @@ describe IncomingMessage, " folding quoted parts of emails" do
 end
 
 describe IncomingMessage, " checking validity to reply to" do
-    def test_email(result, email, return_path, autosubmitted = nil)
-        @address = mock(TMail::Address)
-        @address.stub!(:spec).and_return(email)
-
-        @return_path = mock(TMail::ReturnPathHeader)
-        @return_path.stub!(:addr).and_return(return_path)
-        if !autosubmitted.nil?
-            @autosubmitted = TMail::UnstructuredHeader.new("auto-submitted", autosubmitted)
-        end
-        @mail = mock(TMail::Mail)
-        @mail.stub!(:from_addrs).and_return( [ @address ] )
-        @mail.stub!(:[]).with("return-path").and_return(@return_path)
-        @mail.stub!(:[]).with("auto-submitted").and_return(@autosubmitted)
-
+    def test_email(result, email, empty_return_path, autosubmitted = nil)
+        @mail = mock('mail')
+        MailHandler.stub!(:get_from_address).and_return(email)
+        MailHandler.stub!(:empty_return_path?).with(@mail).and_return(empty_return_path)
+        MailHandler.stub!(:get_auto_submitted).with(@mail).and_return(autosubmitted)
         @incoming_message = IncomingMessage.new()
         @incoming_message.stub!(:mail).and_return(@mail)
         @incoming_message._calculate_valid_to_reply_to.should == result
     end
 
     it "says a valid email is fine" do
-        test_email(true, "team@mysociety.org", nil)
+        test_email(true, "team@mysociety.org", false)
     end
 
     it "says postmaster email is bad" do
-        test_email(false, "postmaster@mysociety.org", nil)
+        test_email(false, "postmaster@mysociety.org", false)
     end
 
     it "says Mailer-Daemon email is bad" do
-        test_email(false, "Mailer-Daemon@mysociety.org", nil)
+        test_email(false, "Mailer-Daemon@mysociety.org", false)
     end
 
     it "says case mangled MaIler-DaemOn email is bad" do
-        test_email(false, "MaIler-DaemOn@mysociety.org", nil)
+        test_email(false, "MaIler-DaemOn@mysociety.org", false)
     end
 
     it "says Auto_Reply email is bad" do
-        test_email(false, "Auto_Reply@mysociety.org", nil)
+        test_email(false, "Auto_Reply@mysociety.org", false)
     end
 
     it "says DoNotReply email is bad" do
-        test_email(false, "DoNotReply@tube.tfl.gov.uk", nil)
+        test_email(false, "DoNotReply@tube.tfl.gov.uk", false)
     end
 
     it "says a filled-out return-path is fine" do
-        test_email(true, "team@mysociety.org", "Return-path: <foo@baz.com>")
+        test_email(true, "team@mysociety.org", false)
     end
 
     it "says an empty return-path is bad" do
-        test_email(false, "team@mysociety.org", "<>")
+        test_email(false, "team@mysociety.org", true)
     end
 
     it "says an auto-submitted keyword is bad" do
-        test_email(false, "team@mysociety.org", nil, "auto-replied")
+        test_email(false, "team@mysociety.org", false, "auto-replied")
     end
 
 end