diff options
| author | Henare Degan <henare.degan@gmail.com> | 2015-04-27 15:08:25 +1000 |
|---|---|---|
| committer | Henare Degan <henare.degan@gmail.com> | 2015-04-27 15:21:05 +1000 |
| commit | 576b88d5ef20ca6aecbf4119d9ac503f36e6375b (patch) | |
| tree | 9585efb81d30d6dd889ee7c5118a229107b9cdf1 | |
| parent | ac8c04e133425745f4e5b6614ff6156255e785d5 (diff) | |
Don't put HTML entities in comment on alert plural email subject lines
| -rw-r--r-- | app/mailers/request_mailer.rb | 2 | ||||
| -rw-r--r-- | spec/mailers/request_mailer_spec.rb | 7 |
2 files changed, 8 insertions, 1 deletions
diff --git a/app/mailers/request_mailer.rb b/app/mailers/request_mailer.rb index 780d6a023..bf04b1ab9 100644 --- a/app/mailers/request_mailer.rb +++ b/app/mailers/request_mailer.rb @@ -209,7 +209,7 @@ class RequestMailer < ApplicationMailer mail(:from => contact_from_name_and_email, :to => info_request.user.name_and_email, - :subject => (_("Some notes have been added to your FOI request - ") + info_request.title).html_safe) + :subject => _("Some notes have been added to your FOI request - ") + info_request.title.html_safe) end # Class function, called by script/mailin with all incoming responses. diff --git a/spec/mailers/request_mailer_spec.rb b/spec/mailers/request_mailer_spec.rb index 506a67953..bed46894d 100644 --- a/spec/mailers/request_mailer_spec.rb +++ b/spec/mailers/request_mailer_spec.rb @@ -471,3 +471,10 @@ describe RequestMailer, "comment_on_alert" do expect(mail.subject).to eq "Somebody added a note to your FOI request - Here's a request" end end + +describe RequestMailer, "comment_on_alert_plural" do + it 'should not create HTML entities in the subject line' do + mail = RequestMailer.comment_on_alert_plural(FactoryGirl.create(:info_request, :title => "Here's a request"), 2, FactoryGirl.create(:comment)) + expect(mail.subject).to eq "Some notes have been added to your FOI request - Here's a request" + end +end |