aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFrancis Irving <francis@mysociety.org>2009-12-22 11:09:21 +0000
committerFrancis Irving <francis@mysociety.org>2009-12-22 11:09:21 +0000
commit69e8341c6f607838238e257c00fc916a09a6e5ee (patch)
treecf059caa681d939654e8d9d5ffa3aa3547176c7f
parente14a80b7fc677089c8a916db24e592669d8b20f5 (diff)
Better error when attachment doesn't get found
-rw-r--r--app/controllers/request_controller.rb1
1 files changed, 1 insertions, 0 deletions
diff --git a/app/controllers/request_controller.rb b/app/controllers/request_controller.rb
index e48ffab72..4005b15eb 100644
--- a/app/controllers/request_controller.rb
+++ b/app/controllers/request_controller.rb
@@ -598,6 +598,7 @@ class RequestController < ApplicationController
raise "internal error, pre-auth filter should have caught this" if !@info_request.user_can_view?(authenticated_user)
@attachment = IncomingMessage.get_attachment_by_url_part_number(@incoming_message.get_attachments_for_display, @part_number)
+ raise "attachment not found part number " + @part_number.to_s + " incoming_message " + @incoming_message.id.to_s if @attachment.nil?
# check filename in URL matches that in database (use a censor rule if you want to change a filename)
raise "please use same filename as original file has, display: '" + @attachment.display_filename + "' old_display: '" + @attachment.old_display_filename + "' original: '" + @original_filename + "'" if @attachment.display_filename != @original_filename && @attachment.old_display_filename != @original_filename