Test for requires admin email.

2 files changed, 29 insertions, 2 deletions

diff --git a/spec/controllers/request_controller_spec.rb b/spec/controllers/request_controller_spec.rb
index a66ec7eaf..72abd89ae 100644
--- a/spec/controllers/request_controller_spec.rb
+++ b/spec/controllers/request_controller_spec.rb
@@ -247,8 +247,23 @@ describe RequestController, "when classifying an individual response" do
         info_requests(:fancy_dog_request).get_last_response_event.calculated_state.should == 'rejected'
     end
 
-        #response.should redirect_to(:action => 'show', :id => info_requests(:fancy_dog_request))
-        #incoming_messages(:useless_incoming_message).user_classified.should == true
+    it "should send email when classified as requires_admin" do
+        info_requests(:fancy_dog_request).awaiting_description.should == true
+        session[:user_id] = users(:bob_smith_user).id
+        post :describe_state, :incoming_message => { :described_state => "requires_admin" }, :id => info_requests(:fancy_dog_request).id, :incoming_message_id => incoming_messages(:useless_incoming_message), :last_info_request_event_id => info_request_events(:silly_comment_event).id, :submitted_describe_state => 1
+        response.should redirect_to(:action => 'show', :url_title => info_requests(:fancy_dog_request).url_title)
+
+        info_requests(:fancy_dog_request).reload
+        info_requests(:fancy_dog_request).awaiting_description.should == false
+        info_requests(:fancy_dog_request).described_state.should == 'requires_admin'
+        info_requests(:fancy_dog_request).get_last_response_event.calculated_state.should == 'requires_admin'
+
+        deliveries = ActionMailer::Base.deliveries
+        deliveries.size.should == 1
+        mail = deliveries[0]
+        mail.body.should =~ /as being unusual/
+        mail.from_addrs.to_s.should == users(:bob_smith_user).name_and_email
+    end
 end
 
 describe RequestController, "when sending a followup message" do
diff --git a/todo.txt b/todo.txt
index acc142686..e68a7254f 100644
--- a/todo.txt
+++ b/todo.txt
@@ -11,6 +11,8 @@ Check foi backup
 Next
 ====
 
+Put name at bottom of request if you are signed in (so don't send them in others names!)
+
 Simple initial bulk request prevention (see Tony's mail on this)
 This doesn't work:
 http://www.whatdotheyknow.com/search/status:waiting_classification/
@@ -20,6 +22,7 @@ Don't let somebody file a new request if they haven't classified all existing on
      - and *after* filing get them to go classify existing ones
 
 Maybe move "send followup" into actions?
+    and make it so you can choose who to send followup to from dropdown
 Maybe make it so you need to log in to send follow up (i.e. before)
 
 Internal review status/marker?
@@ -93,6 +96,15 @@ Admin:
 Later
 =====
 
+Do conversion tracking on endpoints in WDTK, advertise perhaps TWFY, or perhaps
+    donations to mySociety.
+
+http://www.whatdotheyknow.com/list/successful - too many ombudsmans.
+    Radical would be to group by user, regardless of subject; less radical to
+    collate those with same/similar subject.
+http://www.whatdotheyknow.com/list?page=2 - too many monitoring officer
+    reports - similar to above, I reckon.
+
 favicon.ico would be nice
 
 Flag bad comments, delete comments from admin interface