diff options
author | Gareth Rees <gareth@mysociety.org> | 2015-01-09 12:02:53 +0000 |
---|---|---|
committer | Gareth Rees <gareth@mysociety.org> | 2015-01-13 13:52:32 +0000 |
commit | ebf549a966a9c559bfa76b66f4ab86a75c2c1c92 (patch) | |
tree | 7ab6d9af83f1283a78b8aecf99cae98bf2fe0e05 /app/controllers/request_controller.rb | |
parent | 99fb6b483cca96bd55a64bc1137e1070e01b32ba (diff) |
Use a partial to render batch sent message
Dropped the law_used_full interpolation:
So I think there are two significant bits of context here. One is that the
law_used_full attribute is derived from law_used, which in turn is set on
InfoRequest initialisation based on the tags applied to the public body. So
different requests in a batch could have different values for law_used_full
- some of them might be to bodies that only accept environmental
information requests. So using the value from the batch template is not
really a good proxy for the whole collection.
The second is that, in any case, the distinction between the two types of
request is a UK-specific feature which should be moved to the UK theme
(#2085).
Given these two factors, I think the cleanest thing might be to drop
law_used_full from this descriptive text, and just have it say "Your
requests will be sent shortly", without specifying what law will be used.
– Louise Crow (@crowbot)
Diffstat (limited to 'app/controllers/request_controller.rb')
-rw-r--r-- | app/controllers/request_controller.rb | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/app/controllers/request_controller.rb b/app/controllers/request_controller.rb index 56ac396d8..9e156cfb9 100644 --- a/app/controllers/request_controller.rb +++ b/app/controllers/request_controller.rb @@ -244,13 +244,8 @@ class RequestController < ApplicationController :body => params[:outgoing_message][:body], :public_bodies => @public_bodies, :user => authenticated_user) - flash[:notice] = _("<p>Your {{law_used_full}} requests will be <strong>sent</strong> shortly!</p> - <p><strong>We will email you</strong> when they have been sent. - We will also email you when there is a response to any of them, or after {{late_number_of_days}} working days if the authorities still haven't - replied by then.</p> - <p>If you write about these requests (for example in a forum or a blog) please link to this page.</p>", - :law_used_full=>@info_request.law_used_full, - :late_number_of_days => AlaveteliConfiguration::reply_late_after_days) + + flash[:batch_sent] = true redirect_to info_request_batch_path(@info_request_batch) end |