aboutsummaryrefslogtreecommitdiffstats
path: root/app/controllers/user_controller.rb
diff options
context:
space:
mode:
authorGareth Rees <gareth@mysociety.org>2014-10-01 13:00:01 +0100
committerLouise Crow <louise.crow@gmail.com>2014-12-22 17:20:36 +0000
commit39d8eaf778ae21701b10233266d44a4b2217b4a4 (patch)
treebeaaf7d691baf440f146c9d3930089fa49d8344c /app/controllers/user_controller.rb
parent0a1a3536d2d2edb068f84b4a1c21c567ff51ea6a (diff)
Fix unvalidated redirects
Diffstat (limited to 'app/controllers/user_controller.rb')
-rw-r--r--app/controllers/user_controller.rb4
1 files changed, 2 insertions, 2 deletions
diff --git a/app/controllers/user_controller.rb b/app/controllers/user_controller.rb
index a1f546ec0..8b6753579 100644
--- a/app/controllers/user_controller.rb
+++ b/app/controllers/user_controller.rb
@@ -253,7 +253,7 @@ class UserController < ApplicationController
def signout
self._do_signout
if params[:r]
- redirect_to params[:r]
+ redirect_to URI.parse(params[:r]).path
else
redirect_to :controller => "general", :action => "frontpage"
end
@@ -593,7 +593,7 @@ class UserController < ApplicationController
end
@user.receive_email_alerts = params[:receive_email_alerts]
@user.save!
- redirect_to params[:came_from]
+ redirect_to URI.parse(params[:came_from]).path
end
private