Make sure to detect abnormal exits before looking at exit code

1 files changed, 5 insertions, 5 deletions

diff --git a/lib/alaveteli_external_command.rb b/lib/alaveteli_external_command.rb
index fa2512387..086a461c8 100644
--- a/lib/alaveteli_external_command.rb
+++ b/lib/alaveteli_external_command.rb
@@ -44,15 +44,15 @@ module AlaveteliExternalCommand
             end
             xc.run(opts[:stdin_string] || "", opts[:env] || {})
 
-            if xc.status != 0
+            if !xc.exited
+                # Crash or timeout
+                $stderr.puts("#{program_name} #{args.join(' ')}:exited abnormally")
+                return nil
+            elsif xc.status != 0
                 # Error
                 $stderr.puts("Error from #{program_name} #{args.join(' ')}:")
                 $stderr.print(xc.err)
                 return nil
-            elsif !xc.exited
-                # Crash or timeout
-                $stderr.puts("#{program_name} #{args.join(' ')} exited abnormally")
-                return nil
             else
                 if opts.has_key? :append_to
                     opts[:append_to] << "\n\n"