Minor tidying of alert-tracks generation

1 files changed, 10 insertions, 6 deletions

diff --git a/lib/tasks/config_files.rake b/lib/tasks/config_files.rake
index 60814cb27..658f2a01c 100644
--- a/lib/tasks/config_files.rake
+++ b/lib/tasks/config_files.rake
@@ -24,25 +24,29 @@ namespace :config_files do
     desc 'Convert Debian .ugly init script in config to a form suitable for installing in /etc/init.d'
     task :convert_init_script => :environment do
         example = 'rake config_files:convert_init_script DEPLOY_USER=deploy VHOST_DIR=/dir/above/alaveteli SCRIPT_FILE=config/alert-tracks-debian.ugly '
-        check_for_env_vars(['DEPLOY_USER', 'VHOST_DIR', 'SCRIPT_FILE'], example)
+        check_for_env_vars(['DEPLOY_USER',
+                            'VHOST_DIR',
+                            'SCRIPT_FILE'], example)
 
-        deploy_user = ENV['DEPLOY_USER']
-        vhost_dir = ENV['VHOST_DIR']
         script_file = ENV['SCRIPT_FILE']
 
-        replacements = { :user => deploy_user,
-                         :vhost_dir => vhost_dir }
+        replacements = {
+            :user => ENV['DEPLOY_USER'],
+            :vhost_dir => ENV['VHOST_DIR']
+        }
 
         daemon_name = File.basename(script_file, '-debian.ugly')
         replacements.update(:daemon_name => "foi-#{daemon_name}")
         converted = convert_ugly(script_file, replacements)
         rails_env_file = File.expand_path(File.join(Rails.root, 'config', 'rails_env.rb'))
-        if !File.exists?(rails_env_file)
+
+        unless File.exists?(rails_env_file)
             converted.each do |line|
                 line.gsub!(/^#\s*RAILS_ENV=your_rails_env/, "RAILS_ENV=#{Rails.env}")
                 line.gsub!(/^#\s*export RAILS_ENV/, "export RAILS_ENV")
             end
         end
+
         converted.each do |line|
             puts line
         end