Use a partial to render batch sent message

Dropped the law_used_full interpolation:

    So I think there are two significant bits of context here. One is that the
    law_used_full attribute is derived from law_used, which in turn is set on
    InfoRequest initialisation based on the tags applied to the public body. So
    different requests in a batch could have different values for law_used_full
    - some of them might be to bodies that only accept environmental
    information requests. So using the value from the batch template is not
    really a good proxy for the whole collection.

    The second is that, in any case, the distinction between the two types of
    request is a UK-specific feature which should be moved to the UK theme
    (#2085).

    Given these two factors, I think the cleanest thing might be to drop
    law_used_full from this descriptive text, and just have it say "Your
    requests will be sent shortly", without specifying what law will be used.

    – Louise Crow (@crowbot)

1 files changed, 2 insertions, 3 deletions

diff --git a/spec/controllers/request_controller_spec.rb b/spec/controllers/request_controller_spec.rb
index dc28f6dab..aeb27f918 100644
--- a/spec/controllers/request_controller_spec.rb
+++ b/spec/controllers/request_controller_spec.rb
@@ -2564,10 +2564,9 @@ describe RequestController, "#new_batch" do
                     assigns[:existing_batch].should_not be_nil
                 end
 
-                it 'should display a success notice' do
+                it 'sets the batch_sent flash to true' do
                     make_request
-                    notice_text = "<p>Your Freedom of Information requests will be <strong>sent</strong> shortly!"
-                    flash[:notice].should match notice_text
+                    expect(flash[:batch_sent]).to be_true
                 end
 
             end