Fail silently if third party services are broken or unavailable. Fixes #354.

2 files changed, 31 insertions, 6 deletions

diff --git a/spec/controllers/application_controller_spec.rb b/spec/controllers/application_controller_spec.rb
index 875d7d224..1d6802940 100644
--- a/spec/controllers/application_controller_spec.rb
+++ b/spec/controllers/application_controller_spec.rb
@@ -1,10 +1,25 @@
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+require 'fakeweb'
 
-describe ApplicationController, "when authenticating user" do
-    integrate_views
-    fixtures :users
-  
-#    it "blah" do
-#    end
+describe ApplicationController, "when accessing third party services" do
+    it "should fail silently if the country_from_ip domain doesn't exist" do
+        config = MySociety::Config.load_default()
+        config['GAZE_URL'] = 'http://12123sdf14qsd.com'
+        country = self.controller.send :country_from_ip
+        country.should == config['ISO_COUNTRY_CODE']
+    end
+    it "should fail silently if the country_from_ip service doesn't exist" do
+        config = MySociety::Config.load_default()
+        config['GAZE_URL'] = 'http://www.google.com'
+        country = self.controller.send :country_from_ip
+        country.should == config['ISO_COUNTRY_CODE']
+    end
+    it "should fail silently if the country_from_ip service returns an error" do
+        FakeWeb.register_uri(:get, %r|.*|, :body => "Error", :status => ["500", "Error"])
+        config = MySociety::Config.load_default()
+        config['GAZE_URL'] = 'http://500.com'
+        country = self.controller.send :country_from_ip
+        country.should == config['ISO_COUNTRY_CODE']
+    end
 end
 
diff --git a/spec/controllers/general_controller_spec.rb b/spec/controllers/general_controller_spec.rb
index 40a676d61..ad5578800 100644
--- a/spec/controllers/general_controller_spec.rb
+++ b/spec/controllers/general_controller_spec.rb
@@ -1,4 +1,14 @@
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+require 'fakeweb'
+
+describe GeneralController, "when trying to show the blog" do
+    it "should fail silently if the blog is returning an error" do        
+        FakeWeb.register_uri(:get, %r|.*|, :body => "Error", :status => ["500", "Error"])
+        get :blog
+        response.status.should == "200 OK"
+        assigns[:blog_items].count.should == 0
+    end
+end
 
 describe GeneralController, "when searching" do
     integrate_views