Add tests for the external_command library, and fix a bug

(which was actually a fairly late regression, showing the
benefits of formal tests vs informal testing).

I believe this bug was the cause of the recent Xapian indexing errors.

2 files changed, 62 insertions, 0 deletions

diff --git a/spec/lib/external_command_scripts/output.sh b/spec/lib/external_command_scripts/output.sh
new file mode 100755
index 000000000..0472c89a3
--- /dev/null
+++ b/spec/lib/external_command_scripts/output.sh
@@ -0,0 +1,22 @@
+#!/bin/bash
+
+out_msg=${1:-out}
+err_msg=${2:-}
+repeats=${3:-10}
+exit_status=${4:-0}
+
+n=0
+while [ "$n" -lt "$repeats" ]
+do
+  if [ -n "$out_msg" ]
+  then
+    echo "$out_msg $n"
+  fi
+  if [ -n "$err_msg" ]
+  then
+    echo >&2 "$err_msg $n"
+  fi
+  n=$[$n + 1]
+done
+
+exit "$exit_status"
diff --git a/spec/lib/external_command_spec.rb b/spec/lib/external_command_spec.rb
new file mode 100644
index 000000000..0ff1a9c0a
--- /dev/null
+++ b/spec/lib/external_command_spec.rb
@@ -0,0 +1,40 @@
+# This is a test of the external_command library
+
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+script_dir = File.join(File.dirname(__FILE__), 'external_command_scripts')
+output_script = File.join(script_dir, "output.sh")
+
+require 'external_command'
+
+describe "when running ExternalCommand" do
+
+    it "should get correct status code for /bin/true" do
+        t = ExternalCommand.new("/bin/true").run()
+        t.status.should == 0
+        t.out.should == ""
+        t.err.should == ""
+    end
+
+    it "should get correct status code for /bin/false" do
+        f = ExternalCommand.new("/bin/false").run()
+        f.status.should == 1
+        f.out.should == ""
+        f.err.should == ""
+    end
+
+    it "should get stdout and stderr" do
+        f = ExternalCommand.new(output_script, "out", "err", "10", "23").run()
+        f.status.should == 23
+        f.out.should == (0..9).map {|i| "out #{i}\n"}.join("")
+        f.err.should == (0..9).map {|i| "err #{i}\n"}.join("")
+    end
+
+    it "should work with large amounts of data" do
+        f = ExternalCommand.new(output_script, "a longer output line", "a longer error line", "10000", "5").run()
+        f.status.should == 5
+        f.out.should == (0..9999).map {|i| "a longer output line #{i}\n"}.join("")
+        f.err.should == (0..9999).map {|i| "a longer error line #{i}\n"}.join("")
+    end
+
+end
+